Backport pr12384 #12487
Merged
Backport pr12384 #12487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For intercommunicators, passing MPI_IN_PLACE to allreduce is invalid. Signed-off-by: Lisandro Dalcin <[email protected]> (cherry picked from commit cba47b6)
Co-authored-by: Aurelien Bouteiller <[email protected]> Signed-off-by: Lisandro Dalcin <[email protected]> (cherry picked from commit fdc618c)
Signed-off-by: Lisandro Dalcin <[email protected]> (cherry picked from commit b01e156)
|
The ULFM tests are currently being skip with v5.0.x. The following manual CI execution should run these tests: |
`ompi_comm_request_return(req)` releases the internal `req->context`. Therefore, any `OBJ_RELEASE(context->xxx)` **MUST** be called **BEFORE** `ompi_comm_request_return()`, otherwise it is a use-after-free. Signed-off-by: Lisandro Dalcin <[email protected]> (cherry picked from commit 573f35e)
wenduwan
force-pushed
the
backport_pr12384
branch
from
7bccc95
to
ed12d8b
Compare
janjust
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #12384
There was a conflict in ompi/communicator/ft/comm_ft.c that I had to manually resolve.