Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coll_tuned_use_dynamic_rules wrong scoping for tools interface #12593

Open
burlen opened this issue May 31, 2024 · 0 comments · May be fixed by #12639
Open

coll_tuned_use_dynamic_rules wrong scoping for tools interface #12593

burlen opened this issue May 31, 2024 · 0 comments · May be fixed by #12639
Labels
Target: v5.0.x

Comments

@burlen
Copy link

burlen commented May 31, 2024 •
edited
Loading

Background information

What version of Open MPI are you using? (e.g., v4.1.6, v5.0.1, git branch name and hash, etc.)

v5.0.3

Describe how Open MPI was installed (e.g., from a source/distribution tarball, from a git clone, from an operating system distribution package, etc.)

git clone

If you are building/installing from a git clone, please copy-n-paste the output from git submodule status.

Please describe the system on which you are running

  • Operating system/version: ubuntu 22.04
  • Computer hardware: Intel Xeon
  • Network type: Infiniband

Details of the problem

The control variable coll_tuned_use_dynamic_rules is scoped as MCA_BASE_VAR_SCOPE_READONLY. See coll_tuned_component.c:173. The read only scope prevents it from being set programmatically using the MPI_T interface. The scope should be MCA_BASE_VAR_SCOPE_ALL so that it could be set via the MPI_T interface. In particular coll_tuned_use_dynamic_rules must be set to 1 in order to use the other tuning variables. In my case I would like to set coll_tuned_alltoall_algorithm and coll_tuned_alltoall_max_requests programmatically since the latter cannot be set by the "dynamic rules file" method (more info in #12589).
burlen pushed a commit to burlen/ompi that referenced this issue Jun 25, 2024
coll tuned make mca parameters settable via MPI_T
e6368e3 
This changes the scope so that these are settable via MPI_T interface. In
particular making the `use_dynamic_rules` variable settable enables the
variables needed for run time tuning of the individual collectives.
resolves open-mpi#12593
@burlen burlen linked a pull request Jun 25, 2024 that will close this issue
Open
burlen pushed a commit to burlen/ompi that referenced this issue Jun 25, 2024
coll tuned make mca parameters settable via MPI_T
a5fe137 
This changes the scope so that these are settable via MPI_T interface. In
particular making the `use_dynamic_rules` variable settable enables the
variables needed for run time tuning of the individual collectives.
resolves open-mpi#12593

Signed-off-by: Burlen Loring <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Target: v5.0.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

coll tuned make mca parameters settable via MPI_T burlen/ompi
2 participants
@burlen @jsquyres