-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] Fix issue with Laravel Herd #62
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this particularly to a OS? As plenty of other users had an issue with other OS like Mac OS or Linux I'm curious if this will solve all the problems
Also please do check this with WSL so we don't break stuff that was working before (I believe many will not attempt to change all their working environment to Laravel Herd) 😄 |
@d8vjork The code only changes stuff for the Windows OS system. so I will change the PR title. I checked with MacOS. It's working without any issues. For WSL, you mean Laravel Sail, right? I will ask around if someone is already using it. Linux will be tough since I do not have a machine. |
@d8vjork I checked the code, and it does not run the sail command. The format file function does not use sail. Am I missing something? vscode-laravel-pint/src/PintEditService.ts Lines 191 to 193 in 55c3603
|
@vikas5914 That's in the workspace formatting, the save has the pint within sail resolver vscode-laravel-pint/src/PintEditService.ts Lines 125 to 127 in 55c3603
|
I checked the code again, but the function Also, I put the console log in the |
@vikas5914 are you trying to save a changed .php file? Also did you configure the extension so it formats on save (or manually triggering this format) |
@d8vjork d8vjork yes.. I am trying to save a changed.PHP file, and I have set its format to save. This is my settings
|
@d8vjork, any comment on the above info? |
@d8vjork hey.,. any update on this PR? |
Fix #61