use TypedArray as parameter?

[asukaminato0721]

fsrs-rs-nodejs/src/lib.rs

Lines 35 to 42 in 343e9fd

	pub fn new(parameters: Option<Vec<JsNumber>>) -> Self {
	let params: [f32; 19] = match parameters {
	Some(parameters) => {
	let mut array = [0.0; 19];
	for (i, value) in parameters.iter().enumerate().take(19) {
	array[i] = value.get_double().unwrap_or(0.0) as f32;
	}
	array

ref https://napi.rs/cn/docs/concepts/typed-array

well, currently the code work, so don't touch it.

[asukaminato0721]

@ishiko732

[ishiko732]

If using a TypedArray, I must wrap the parameter with Float32Array

+  pub fn new(parameters: Option<&[f32]>) -> Self {
    let params: Vec<f32> = match parameters {
+    Some(parameters) => parameters.into_iter().map(|p| *p as f32).collect(),
      None => DEFAULT_PARAMETERS.to_vec(),
    };
    Self(Arc::new(Mutex::new(
      fsrs::FSRS::new(Some(&params)).unwrap(),
    )))
  }

  async function computeParametersWrapper(enableShortTerm) {
    // create FSRS instance and optimize
    const fsrs = new FSRS(null)
    const optimizedParameters = await fsrs.computeParameters(
      fsrsItems,
      enableShortTerm,
      progress.bind(null, enableShortTerm),
      1000 /** 1s */,
    )
    console.log(`[enableShortTerm=${enableShortTerm}]optimized parameters:`, optimizedParameters)
-    const model = new FSRS(optimizedParameters) // Error: Get TypedArray info failed
+    const model = new FSRS(Float32Array.from(optimizedParameters))

    const metrics = model.evaluate(fsrsItems)
    console.log(`[enableShortTerm=${enableShortTerm}]metrics:`, metrics)
  }