Add support for logs in cloudfoundryreceiver #33044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… config Co-authored-by: Jose Riguera <[email protected]> Co-authored-by: Sam Clulow <[email protected]>
…ogs to the receiver Co-authored-by: Jose Riguera <[email protected]> Co-authored-by: Sam Clulow <[email protected]>
Co-authored-by: Cem Deniz Kabakci <[email protected]>
Co-authored-by: Cem Deniz Kabakci <[email protected]>
Co-authored-by: Jose Riguera <[email protected]>
… tests (now part of config tests). Fix parameters for test function Co-authored-by: Cem Deniz Kabakci <[email protected]>
… to now, instead of when the receiver starts Co-authored-by: Jose Riguera <[email protected]>
…id and span id from RTR Logs Co-authored-by: Jose Riguera <[email protected]>
Co-authored-by: Jose Riguera <[email protected]>
…velopment Co-authored-by: Sam Clulow <[email protected]> Co-authored-by: Cem Deniz Kabakci <[email protected]>
Co-authored-by: Sam Clulow <[email protected]> Co-authored-by: Cem Deniz Kabakci <[email protected]>
Co-authored-by: Sam Clulow <[email protected]> Co-authored-by: Cem Deniz Kabakci <[email protected]>
Co-authored-by: Sam Clulow <[email protected]> Co-authored-by: Cem Deniz Kabakci <[email protected]>
|
|
crobert-1
reviewed
May 16, 2024
|
@CemDK Can you please sign the CLA? |
Done! |
…R log lines extracting fields and add tests Co-authored-by: Cem Deniz Kabakci <[email protected]>
…e telemetryType from cloudFoundryReceiver struct Co-authored-by: Cem Deniz Kabakci <[email protected]>
Co-authored-by: Cem Deniz Kabakci <[email protected]>
* Original CreateStream fucntion was returning a tuple `(loggregator.EnvelopeStream, error)`, but error was always nil, because the upstream funcion from loggregator `rgc.rlpGatewayClient.Stream` does not fail. * No need to check the error in tests and in the receiver (it was always nil) * CreateStream splitted in 2 funcions, each applies the filters each one needs, no need to pass aditional parameters to select filters.
crobert-1
added
the
ready to merge
codeboten
reviewed
Jun 19, 2024
codeboten
approved these changes
Jun 19, 2024
This was referenced Jun 19, 2024
This was referenced Jun 20, 2024
|
Code owners @agoallikmaa @pellared please review |
|
NVM I missed the |
TylerHelmuth
approved these changes
Jul 1, 2024
TylerHelmuth
removed
the
ready to merge
|
@jriguera please get the latest from main |
@TylerHelmuth done! |
|
Fixing the tests |
…for loop Co-authored-by: Sam Clulow <[email protected]> Co-authored-by: Cem Deniz Kabakci <[email protected]> Co-authored-by: Tomas Mota <[email protected]>
crobert-1
added
the
ready to merge
Co-authored-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding support receive logs from Cloudfoundry.
Link to tracking Issue: #32671
Testing: Basic testing inline with the current tests
Documentation:
rlp_gateway.shard_id).cc @CemDK @m1rp