Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[service] Update pseudoversions for hostcapabilities #12462

Closed
mx-psi opened this issue Feb 24, 2025 · 3 comments · Fixed by #12517
Closed

[service] Update pseudoversions for hostcapabilities #12462

mx-psi opened this issue Feb 24, 2025 · 3 comments · Fixed by #12517
Assignees
@jackgopack4

Comments

@mx-psi
Copy link
Member

mx-psi commented Feb 24, 2025

#12375 added a new module, we need to follow step 5 of the coding guidelines to finalize adding this module.
@mx-psi mx-psi mentioned this issue Feb 24, 2025
Merged
@jackgopack4
Copy link
Contributor

will get this knocked out today

@jackgopack4 jackgopack4 mentioned this issue Feb 27, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 27, 2025
@jackgopack4
[chore] update service/hostcapabilities to pseudoversion (#12517)
beb9002 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
pin service/hostcapabilities to existing pseudoversion prior to
publishing v0.121.0
<!-- Issue number if applicable -->
#### Link to tracking issue
Fixes #12462

<!--Describe what testing was performed and which tests were added.-->
#### Testing
none, gomod version updated only
<!--Describe the documentation added.-->
#### Documentation
none, no change to API or user
<!--Please delete paragraphs that you did not use before submitting.-->
@dmitryax
Copy link
Member

dmitryax commented Feb 27, 2025 •
edited
Loading

@mx-psi do we want to do the same as #12517 for extension/extensionauth and extension/extensionauth/extensionauthtest? I just saw that PR. That would help to remove replaces added in open-telemetry/opentelemetry-collector-contrib#38214 earlier

@jackgopack4 jackgopack4 mentioned this issue Feb 27, 2025
Merged
@jackgopack4
Copy link
Contributor

@dmitryax just did the same for those two modules if you want to give that a review #12521. ran into the issue on my feature branch in contrib separately before even seeing your comment here. thanks.

github-merge-queue bot pushed a commit that referenced this issue Feb 27, 2025
@jackgopack4
[chore] pin extensionauth and extensionauthtest to published version (#…
443e0bc 
…12521)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
pins newly created modules to existing version
<!-- Issue number if applicable -->
#### Link to tracking issue
Fixes #12520, relates to #12462

<!--Describe what testing was performed and which tests were added.-->
#### Testing
existing testing framework
<!--Describe the documentation added.-->
#### Documentation
none, no api or user-facing changes
<!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackgopack4 jackgopack4

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore] update service/hostcapabilities to pseudoversion DataDog/opentelemetry-collector
3 participants
@mx-psi @jackgopack4 @dmitryax