Remove exporterqueue.Factory and simplify exportehelper.WithQueueRequest #12509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
new-queue-factory
branch
3 times, most recently
from
af1f856 to
5bdc715
Compare
bogdandrutu
requested review from
a team,
mx-psi,
dmathieu and
dmitryax
as code owners
bogdandrutu
changed the title
bogdandrutu
changed the title
bogdandrutu
force-pushed
the
new-queue-factory
branch
3 times, most recently
from
4b22b2c to
096ef99
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (87.17%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #12509 +/- ##
=======================================
Coverage 92.00% 92.00%
=======================================
Files 469 469
Lines 25355 25301 -54
=======================================
- Hits 23327 23279 -48
+ Misses 1619 1614 -5
+ Partials 409 408 -1 ☔ View full report in Codecov by Sentry. |
dmitryax
reviewed
Feb 28, 2025
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
new-queue-factory
branch
from
096ef99 to
7243d9a
Compare
dmitryax
approved these changes
Feb 28, 2025
Merged
via the queue into
open-telemetry:main
with commit Feb 28, 2025
d510c86
60 of 62 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to tracking issue
Fixes #
Testing
Documentation