Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Improve logs bytes batch #12529

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Mar 1, 2025

Before:

BenchmarkSplittingBasedOnItemCountManyLogsSlightlyAboveLimit
BenchmarkSplittingBasedOnItemCountManyLogsSlightlyAboveLimit-12    	      51	  23075717 ns/op	43531254 B/op	  700472 allocs/op
BenchmarkSplittingBasedOnByteSizeManyLogsSlightlyAboveLimit
BenchmarkSplittingBasedOnByteSizeManyLogsSlightlyAboveLimit-12    	      36	  32852065 ns/op	43601205 B/op	  702094 allocs/op

After:

BenchmarkSplittingBasedOnItemCountManyLogsSlightlyAboveLimit
BenchmarkSplittingBasedOnItemCountManyLogsSlightlyAboveLimit-12    	      50	  23387806 ns/op	43531234 B/op	  700471 allocs/op
BenchmarkSplittingBasedOnByteSizeManyLogsSlightlyAboveLimit
BenchmarkSplittingBasedOnByteSizeManyLogsSlightlyAboveLimit-12    	      30	  38350051 ns/op	43616507 B/op	  702427 allocs/op

@bogdandrutu bogdandrutu requested review from dmitryax and a team as code owners March 1, 2025 04:13
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

Attention: Patch coverage is 98.30508% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.02%. Comparing base (d510c86) to head (df738f9).

Files with missing lines Patch % Lines
exporter/exporterhelper/logs_batch.go 98.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12529      +/-   ##
==========================================
+ Coverage   92.00%   92.02%   +0.01%     
==========================================
  Files         469      469              
  Lines       25301    25318      +17     
==========================================
+ Hits        23279    23299      +20     
+ Misses       1614     1612       -2     
+ Partials      408      407       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant