Skip to content

Commit 121d6c6

Browse files
committed
Address feedback
1 parent fcebda2 commit 121d6c6

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

CHANGELOG.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,7 @@ Increment the:
3333
* [BUILD] Use -dev versions in main branch
3434
[#3609](https://github.com/open-telemetry/opentelemetry-cpp/pull/3609)
3535

36-
* [SDK] Implementing configurable aggregation cardinality limit and collector
37-
emitting all views instead of last view
36+
* [SDK] Implementing configurable aggregation cardinality limit
3837
[#3624](https://github.com/open-telemetry/opentelemetry-cpp/pull/3624)
3938

4039
Important changes:

sdk/include/opentelemetry/sdk/metrics/state/sync_metric_storage.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ class SyncMetricStorage : public MetricStorage, public SyncWritableMetricStorage
6666
const AggregationConfig *aggregation_config)
6767
: instrument_descriptor_(instrument_descriptor),
6868
aggregation_config_(aggregation_config),
69-
attributes_hashmap_(new AttributesHashMap(aggregation_config
69+
attributes_hashmap_(std::make_unique<AttributesHashMap>(aggregation_config
7070
? aggregation_config->cardinality_limit_
7171
: kAggregationCardinalityLimit)),
7272
attributes_processor_(std::move(attributes_processor)),

0 commit comments

Comments
 (0)