Skip to content

Commit 0a99c70

Browse files
committed
Fix some linter issues
1 parent ed667f5 commit 0a99c70

File tree

1 file changed

+11
-10
lines changed

1 file changed

+11
-10
lines changed

interpreter/beam/beam.go

+11-10
Original file line numberDiff line numberDiff line change
@@ -56,24 +56,25 @@ func readSymbolValue(ef *pfelf.File, name libpf.SymbolName) ([]byte, error) {
5656
log.Infof("read symbol value %s: %s", sym.Name, memory)
5757
return memory, nil
5858
}
59+
5960
func readReleaseVersion(ef *pfelf.File) (uint32, []byte, error) {
60-
otp_release, err := readSymbolValue(ef, "etp_otp_release")
61+
otpRelease, err := readSymbolValue(ef, "etp_otp_release")
6162
if err != nil {
6263
return 0, nil, fmt.Errorf("failed to read OTP release: %v", err)
6364
}
6465

6566
// Slice off the null termination before converting
66-
otp_major, err := strconv.Atoi(string(otp_release[:len(otp_release)-1]))
67+
otpMajor, err := strconv.Atoi(string(otpRelease[:len(otpRelease)-1]))
6768
if err != nil {
6869
return 0, nil, fmt.Errorf("failed to parse OTP version: %v", err)
6970
}
7071

71-
erts_version, err := readSymbolValue(ef, "etp_erts_version")
72+
ertsVersion, err := readSymbolValue(ef, "etp_erts_version")
7273
if err != nil {
7374
return 0, nil, fmt.Errorf("failed to read erts version: %v", err)
7475
}
7576

76-
return uint32(otp_major), erts_version, nil
77+
return uint32(otpMajor), ertsVersion, nil
7778
}
7879

7980
func Loader(ebpf interpreter.EbpfHandler, info *interpreter.LoaderInfo) (interpreter.Data, error) {
@@ -88,7 +89,7 @@ func Loader(ebpf interpreter.EbpfHandler, info *interpreter.LoaderInfo) (interpr
8889
return nil, err
8990
}
9091

91-
otp_version, _, err := readReleaseVersion(ef)
92+
otpVersion, _, err := readReleaseVersion(ef)
9293
if err != nil {
9394
return nil, err
9495
}
@@ -104,11 +105,10 @@ func Loader(ebpf interpreter.EbpfHandler, info *interpreter.LoaderInfo) (interpr
104105
}
105106

106107
d := &beamData{
107-
version: otp_version,
108+
version: otpVersion,
108109
}
109110

110-
log.Infof("BEAM loaded, otp_version: %d, interpRanges: %v", otp_version, interpRanges)
111-
//d.loadIntrospectionData()
111+
log.Infof("BEAM loaded, otpVersion: %d, interpRanges: %v", otpVersion, interpRanges)
112112

113113
return d, nil
114114
}
@@ -121,11 +121,12 @@ func (d *beamData) Attach(ebpf interpreter.EbpfHandler, pid libpf.PID, bias libp
121121
}, nil
122122
}
123123

124-
func (r *beamInstance) Detach(ebpf interpreter.EbpfHandler, pid libpf.PID) error {
124+
func (i *beamInstance) Detach(interpreter.EbpfHandler, libpf.PID) error {
125+
log.Infof("BEAM interpreter detaching")
125126
return nil
126127
}
127128

128-
func (r *beamInstance) Symbolize(symbolReporter reporter.SymbolReporter, frame *host.Frame, trace *libpf.Trace) error {
129+
func (i *beamInstance) Symbolize(symbolReporter reporter.SymbolReporter, frame *host.Frame, trace *libpf.Trace) error {
129130
if !frame.Type.IsInterpType(libpf.BEAM) {
130131
log.Warnf("BEAM failed to symbolize")
131132
return interpreter.ErrMismatchInterpreterType

0 commit comments

Comments
 (0)