otlptracehttp modifying endpoint #2597
julianocosta89
started this conversation in
General
Replies: 1 comment 1 reply
-
The endpoint is http(s)://host+port |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hello all! 👋🏽
I'd like to open a discussion about something that I recently came across.
Is there a reason behind the options of otlptracehttp have the function WithURLPath?
Also, any reason the scheme being added to the endpoint?
I mean, if the user define the endpoint to something like:
https://otel-collector:4317
the config is failing, because it automatically prependshttps://
, resulting in the URLhttps://https/://otel-collector:4317
.As of the specification, I don't believe it should work like that, am I wrong?
For Endpoint (OTLP/HTTP), we have the following:
The endpoint MUST be a valid URL with scheme (http or https) and host, MAY contain a port, SHOULD contain a path and MUST NOT contain other parts (such as query string or fragment).
I believe when we modify the endpoint adding or removing the scheme, we are going against that paragraph.
Can't we simply use the
endpoint
as it is when using theWithEndpoint
function?Beta Was this translation helpful? Give feedback.
All reactions