From 032a19d84bf6bcee0a60523b74dd2ebe209dad72 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Robert=20Paj=C4=85k?= Date: Fri, 23 Jun 2023 14:02:47 +0200 Subject: [PATCH 1/2] Document f in RegisterCallback needs to be concurrent safe --- metric/meter.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/metric/meter.go b/metric/meter.go index 8e1917c3214..35ff0dd3c94 100644 --- a/metric/meter.go +++ b/metric/meter.go @@ -157,6 +157,8 @@ type Meter interface { // // If no instruments are passed, f should not be registered nor called // during collection. + // + // The f function needs to be concurrent safe. RegisterCallback(f Callback, instruments ...Observable) (Registration, error) } From 911420af85abc2df9ba5fdc7223c2de78a18a6d0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Robert=20Paj=C4=85k?= Date: Tue, 27 Jun 2023 23:18:38 +0200 Subject: [PATCH 2/2] Update metric/meter.go Co-authored-by: Tyler Yahn --- metric/meter.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/metric/meter.go b/metric/meter.go index 35ff0dd3c94..2520bc74af1 100644 --- a/metric/meter.go +++ b/metric/meter.go @@ -158,7 +158,7 @@ type Meter interface { // If no instruments are passed, f should not be registered nor called // during collection. // - // The f function needs to be concurrent safe. + // The function f needs to be concurrent safe. RegisterCallback(f Callback, instruments ...Observable) (Registration, error) }