Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcp-resources documentation doesn't align with the GCP Resource Detector #1609

Open
bcarter97 opened this issue Dec 16, 2024 · 1 comment · May be fixed by #1621
Open

gcp-resources documentation doesn't align with the GCP Resource Detector #1609

bcarter97 opened this issue Dec 16, 2024 · 1 comment · May be fixed by #1621

Comments

@bcarter97
Copy link

The GCP Resource Detector mentions - and contains docs for - k8s Resource attributes. However, none of them aside from k8s.cluser.name appear to be instrumented:

public static final AttributeKey<String> K8S_CLUSTER_NAME =
AttributeKey.stringKey("k8s.cluster.name");

It looks like they exist in the GCP Resource Translator, so they're only missing in the Otel side. I noticed they're in the IncubatingAttributes so perhaps they're still in development?

@psx95
Copy link
Contributor

psx95 commented Dec 19, 2024

Hi @bcarter97 ,
Thank you for raising this. This is a documentation issue.

The GCP Resource detector in Go has documentation on how to set these k8s attributes.

The resource detector by design does not detect these attributes.
I will update the documentation in RADME to reflect that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants