amqplib add option/hook for base span

[vabatta]

Is it possible to add an option or an hook for the default span created in

opentelemetry-js-contrib/packages/instrumentation-amqplib/src/amqplib.ts

Lines 416 to 447 in ca26f63

	if (self._config.useLinksForConsume) {
	const parentSpanContext = parentContext
	? trace.getSpan(parentContext)?.spanContext()
	: undefined;
	parentContext = undefined;
	if (parentSpanContext) {
	links = [
	{
	context: parentSpanContext,
	},
	];
	}
	}
	const span = self.tracer.startSpan(
	`${queue} process`,
	{
	kind: SpanKind.CONSUMER,
	attributes: {
	...channel?.connection?.[CONNECTION_ATTRIBUTES],
	[SEMATTRS_MESSAGING_DESTINATION]: exchange,
	[SEMATTRS_MESSAGING_DESTINATION_KIND]:
	MESSAGINGDESTINATIONKINDVALUES_TOPIC,
	[SEMATTRS_MESSAGING_RABBITMQ_ROUTING_KEY]: msg.fields?.routingKey,
	[SEMATTRS_MESSAGING_OPERATION]: MESSAGINGOPERATIONVALUES_PROCESS,
	[SEMATTRS_MESSAGING_MESSAGE_ID]: msg?.properties.messageId,
	[SEMATTRS_MESSAGING_CONVERSATION_ID]:
	msg?.properties.correlationId,
	},
	links,
	},
	parentContext
	);

as passing undefined as the parentContext makes it pick up the current active context, and an option to control that would be great.

If one uses useLinksForConsume, the span gets created under the previously active spanContext which might make things very hard for understanding where the span gets added (despite the links). It would be nice to add control over it, for example to set root: true so that the span creates a new trace that it is linked to the publish one.

For example, using @opentelemetry/instrumentation-nestjs-core all consumers with useLinksForConsume will end up in the Create Nest App (

opentelemetry-js-contrib/packages/instrumentation-nestjs-core/src/instrumentation.ts

Lines 124 to 131 in ca26f63

	const span = tracer.startSpan('Create Nest App', {
	attributes: {
	...NestInstrumentation.COMMON_ATTRIBUTES,
	[AttributeNames.TYPE]: NestType.APP_CREATION,
	[AttributeNames.VERSION]: moduleVersion,
	[AttributeNames.MODULE]: nestModule.name,
	},
	});

) which doesn't really make sense.

[vabatta]

diff --git a/node_modules/@opentelemetry/instrumentation-amqplib/build/src/amqplib.js b/node_modules/@opentelemetry/instrumentation-amqplib/build/src/amqplib.js
index 5cfc731..5f2baf6 100644
--- a/node_modules/@opentelemetry/instrumentation-amqplib/build/src/amqplib.js
+++ b/node_modules/@opentelemetry/instrumentation-amqplib/build/src/amqplib.js
@@ -212,7 +212,7 @@ class AmqplibInstrumentation extends instrumentation_1.InstrumentationBase {
                     const parentSpanContext = parentContext
                         ? api_1.trace.getSpan(parentContext)?.spanContext()
                         : undefined;
-                    parentContext = undefined;
+                    parentContext = api_1.ROOT_CONTEXT;
                     if (parentSpanContext) {
                         links = [
                             {

This is how I solved for the time being.