Create service for extensions #3403
Open
+415
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ankit152
force-pushed
the
service-extension
branch
from
df4a731
to
3a5a2ee
Compare
yurishkuro
reviewed
Oct 28, 2024
Ankit152
force-pushed
the
service-extension
branch
from
3a5a2ee
to
3ab8c98
Compare
iblancasa
reviewed
Oct 29, 2024
iblancasa
reviewed
Oct 29, 2024
pavolloffay
reviewed
Oct 29, 2024
Ankit152
force-pushed
the
service-extension
branch
2 times, most recently
from
d742325
to
eb14bf7
Compare
Ankit152
force-pushed
the
service-extension
branch
from
eb14bf7
to
5f26d14
Compare
yurishkuro
reviewed
Nov 7, 2024
Ankit152
force-pushed
the
service-extension
branch
6 times, most recently
from
007c7eb
to
d9ff5df
Compare
swiatekm
reviewed
Nov 13, 2024
iblancasa
reviewed
Nov 14, 2024
Ankit152
force-pushed
the
service-extension
branch
2 times, most recently
from
41da859
to
5e26224
Compare
Ankit152
force-pushed
the
service-extension
branch
from
5e26224
to
4f27a6b
Compare
swiatekm
reviewed
Nov 21, 2024
There was a problem hiding this comment.
I wanted to be clearer about how I'd like the e2e test you added to look like. I'm including some suggestions to help demonstrate that. Fundamentally, the manifests we assert against should only contain attributes that are relevant to this specific test.
The rest of this PR looks good to me, nicely done. 👍
Ankit152
force-pushed
the
service-extension
branch
2 times, most recently
from
c5d4b40
to
effe1d9
Compare
iblancasa
approved these changes
Nov 22, 2024
Ankit152
force-pushed
the
service-extension
branch
from
effe1d9
to
d25d89a
Compare
Signed-off-by: Ankit152 <[email protected]>
Signed-off-by: Ankit152 <[email protected]>
Signed-off-by: Ankit152 <[email protected]>
Signed-off-by: Ankit152 <[email protected]>
Ankit152
force-pushed
the
service-extension
branch
from
d25d89a
to
0091576
Compare
swiatekm
approved these changes
Nov 22, 2024
jaronoff97
reviewed
Nov 22, 2024
| @@ -321,6 +321,161 @@ func TestMonitoringService(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestExtensionService(t *testing.T) { | |||
There was a problem hiding this comment.
nit... can you change this to be a list test instead here and also assert on the service created to be sure it has the right ports set?
There was a problem hiding this comment.
Okay, I understood about asserting the ports. But can you elaborate more on list test instead? Do you mean something like this:
func TestExtensionService(t *testing.T) {
tests := []struct{
name. string
params manifests.params
ports []corev1.ServicePort
expectedErr error
}{
{
....
....
},
{
....
....
},
}
for _,tc := range tests {
t.Run(tc.name, func (t *testing.T){
// assertion
})
}
There was a problem hiding this comment.
yep! you can see an example here for these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The Otel Operator doesn't creates a service for extensions. This will help the operator to create Service for extensions which will be consumed by an Ingress so that users can interact with it directly. This is related to deployment of Jaeger V2 in k8s.
Link to tracking Issue(s):
Testing:
Documentation: