Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to disable watching for OpenTelemetryCollector CRDs #3568

Open
atoulme opened this issue Dec 21, 2024 · 5 comments
Open

Ability to disable watching for OpenTelemetryCollector CRDs #3568

atoulme opened this issue Dec 21, 2024 · 5 comments
Labels
enhancement New feature or request needs triage

Comments

@atoulme
Copy link

atoulme commented Dec 21, 2024

Component(s)

auto-instrumentation

Is your feature request related to a problem? Please describe.

The manager currently registers to watch for opentelemetrycollector CRDs and fails if those are not defined or if its permissions are lacking.

Describe the solution you'd like

This watcher should be optional.

Describe alternatives you've considered

No response

Additional context

No response

@atoulme atoulme added enhancement New feature or request needs triage labels Dec 21, 2024
@jaronoff97
Copy link
Contributor

jaronoff97 commented Dec 23, 2024

@atoulme IIRC this was a design choice. If the operator cannot watch for the collector CRDs, it wouldn't be able to do it's purpose? Can you explain more about the reasoning behind this request?

@atoulme
Copy link
Author

atoulme commented Dec 24, 2024

My purpose is to use the operator only to instrument applications, and I run my collector deployment in a different manner.

@jaronoff97
Copy link
Contributor

i understand that, but despite not running your collectors this way you can install the CRDs and do nothing with them. For optional CRDs that are not necessarily part of the project we can enable and disable some amount of this, but I'm not sure we would want to do this for the core collector functionality.

@atoulme
Copy link
Author

atoulme commented Dec 24, 2024

Why is that?

@atoulme
Copy link
Author

atoulme commented Dec 28, 2024

Here is an example showing how to execute on this approach, with a much smaller footprint:
https://github.com/otel-warez/whitegloves-operator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage
Projects
None yet
Development

No branches or pull requests

2 participants