Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[confluent-kafka] Add wrapper to 'consume' method for batch messages #1747

Closed
faunris opened this issue Apr 11, 2023 · 4 comments · Fixed by #1786
Closed

[confluent-kafka] Add wrapper to 'consume' method for batch messages #1747

faunris opened this issue Apr 11, 2023 · 4 comments · Fixed by #1786
Assignees
Labels
feature-request help wanted Extra attention is needed

Comments

@faunris
Copy link

faunris commented Apr 11, 2023

Is your feature request related to a problem?
If we use consumer.consume(num_messages=100) src for receiving messages, ConfluentKafkaInstrumentor doesn't send spans for this.

Describe the solution you'd like
ConfluentKafkaInstrumentor should wrap consume method the same as the poll method.

Additional context
We could add messaging.batch.message_count to semconv and use it in a span tag. Relates to batch-receiving in opentelemetry-semantic-conventions.

@srikanthccv srikanthccv added the help wanted Extra attention is needed label Apr 14, 2023
@javferrod
Copy link
Contributor

javferrod commented May 4, 2023

Hi! It seems like a good issue to start contributing. Can I take it?

The addition of messaging.batch.message_count needs the v1.17.0 of semconv. I cannot add it until this PR is merged, but I can wrap the consume method using the same implementation of poll wrapper if that's okay.

@javferrod
Copy link
Contributor

Hi! I opened the PR that fixes this issue a bit ago. How may I help to get it merged?

@Samira-El
Copy link

Hi, any updates on this? This will be great to have

@javferrod
Copy link
Contributor

Hi @Samira-El, the PR should be ready. I think it could be merged if @ocelotl is happy with the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants