Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelemetry-instrumentation-asyncio is failing #2688

Closed
ocelotl opened this issue Jul 10, 2024 · 0 comments · Fixed by #2690
Closed

opentelemetry-instrumentation-asyncio is failing #2688

ocelotl opened this issue Jul 10, 2024 · 0 comments · Fixed by #2690
Labels
bug Something isn't working

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Jul 10, 2024

The tests for opentelemetry-instrumentation-asyncio fail in CI.

I realized this was happening when working on #2687. We hadn't realized this before because we didn't realize we were not including the tests for this package in our Github workflow files.

@ocelotl ocelotl added the bug Something isn't working label Jul 10, 2024
xrmx added a commit to xrmx/opentelemetry-python-contrib that referenced this issue Jul 10, 2024
After a29242f we are re-raising the
CancelledError so we need to catch it on the caller side.

Fix open-telemetry#2688
ocelotl pushed a commit that referenced this issue Jul 10, 2024
* instrumentation/asyncio: catch CancelledError exception in tests

After a29242f we are re-raising the
CancelledError so we need to catch it on the caller side.

Fix #2688

* instrument/asyncio: don't test anext on python < 3.10

Since it's not available there.

* instrumentation/asyncio: use unittest.skipIf instead of reimplementing it

---------

Co-authored-by: Leighton Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant