We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OS: Ubuntu 22.04 Python version: 3.10.12 Package version: 0.47b0
The WebSocketHandler.finish method, called after the WebSocket upgrade, results in lost context at https://github.com/tornadoweb/tornado/blob/1f8b2d78fee5e5a15e686815e0285d4a3c831a2c/tornado/websocket.py#L929
WebSocketHandler.finish
from tornado import websocket, web, ioloop class WebsocketHandler(websocket.WebSocketHandler): def open(self): print("WebSocket opened") def on_message(self, message): self.write_message(u"You said: " + message) def on_close(self): print("WebSocket closed") app = web.Application([ (r'/ws', WebsocketHandler), ]) if __name__ == '__main__': app.listen(8888) ioloop.IOLoop.instance().start()
opentelemetry-instrument \ --traces_exporter console \ --metrics_exporter console \ --logs_exporter console \ --service_name cmc-front-end \ python \ main.py
const ws = new WebSocket("ws://localhost:8888/ws"); ws.onopen = function() { ws.send("Hello, world"); }; ws.onmessage = function (evt) { console.log(evt) };
deno run main.js
Context to flow from the protocol upgrade to the message handling.
Context is lost after the initial phase is finished.
No response
Yes
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Describe your environment
OS: Ubuntu 22.04
Python version: 3.10.12
Package version: 0.47b0
What happened?
The
WebSocketHandler.finish
method, called after the WebSocket upgrade, results in lost context at https://github.com/tornadoweb/tornado/blob/1f8b2d78fee5e5a15e686815e0285d4a3c831a2c/tornado/websocket.py#L929Steps to Reproduce
Expected Result
Context to flow from the protocol upgrade to the message handling.
Actual Result
Context is lost after the initial phase is finished.
Additional context
No response
Would you like to implement a fix?
Yes
The text was updated successfully, but these errors were encountered: