From 6dd85fcf6934a2a5dbe8684d2c3d62190200fe3d Mon Sep 17 00:00:00 2001 From: John Bley Date: Wed, 20 Mar 2024 18:00:27 -0400 Subject: [PATCH] Fix shellcheck --severity=warning issues (#3789) Co-authored-by: Diego Hurtado --- scripts/build.sh | 4 ++-- scripts/coverage.sh | 3 --- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/scripts/build.sh b/scripts/build.sh index 46b6f1289f..4a049b23fe 100755 --- a/scripts/build.sh +++ b/scripts/build.sh @@ -8,13 +8,13 @@ set -ev # Get the latest versions of packaging tools python3 -m pip install --upgrade pip build setuptools wheel -BASEDIR=$(dirname $(readlink -f $(dirname $0))) +BASEDIR=$(dirname "$(readlink -f "$(dirname $0)")") DISTDIR=dist ( cd $BASEDIR mkdir -p $DISTDIR - rm -rf $DISTDIR/* + rm -rf ${DISTDIR:?}/* for d in opentelemetry-api/ opentelemetry-sdk/ opentelemetry-proto/ opentelemetry-semantic-conventions/ exporter/*/ shim/opentelemetry-opentracing-shim/ propagator/*/ tests/opentelemetry-test-utils/; do ( diff --git a/scripts/coverage.sh b/scripts/coverage.sh index 56cbc78dde..99dce84878 100755 --- a/scripts/coverage.sh +++ b/scripts/coverage.sh @@ -22,9 +22,6 @@ function cov { fi } -PYTHON_VERSION=$(python -c 'import sys; print(".".join(map(str, sys.version_info[:3])))') -PYTHON_VERSION_INFO=(${PYTHON_VERSION//./ }) - coverage erase cov opentelemetry-api