Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several bugs with metrics aggregation #3418

Closed
ocelotl opened this issue Aug 30, 2023 · 1 comment
Closed

Several bugs with metrics aggregation #3418

ocelotl opened this issue Aug 30, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Aug 30, 2023

We have several bugs in our implementation of metrics aggregations.

Race condition on MetricReader.collect when using asynchronous instruments

Fixed in #3335 here.

We wrongly calculate the value for a point using delta temporality

Fixed in #3390

We produce MetricsData without any data points if an aggregation returns None

Fixed in #3335 here.

We produce metrics when using a synchronous instrument and delta temporality when no measurements were taken since last collection cycle

This was discussed during the previous SIG. It was suggested to produce 0-valued points instead of producing no points at all. We should not do that but do not return any points at all, the spec says so:

For synchronous instruments with Delta aggregation temporality, MetricReader.Collect MUST only receive data points with measurements recorded since the previous collection.

We don't keep producing metrics using ExplicitBucketHistogramAggregation and cumulative temporality even if no new data is produced after a collection cycle

As mentioned here

@ocelotl ocelotl added the bug Something isn't working label Aug 30, 2023
@ocelotl ocelotl self-assigned this Aug 30, 2023
@ocelotl
Copy link
Contributor Author

ocelotl commented Feb 14, 2024

Every issue mentioned above is fixed.

@ocelotl ocelotl closed this as completed Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant