From cc1d34526fe6f34dfcd2586d9e90cc41f87bbc5c Mon Sep 17 00:00:00 2001 From: Abinet Date: Thu, 28 Sep 2023 17:40:56 -0700 Subject: [PATCH] fix tests , fix enable and disable to act on patching history api --- pkgs/instrumentations/web/page-view/test/pageView.test.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkgs/instrumentations/web/page-view/test/pageView.test.ts b/pkgs/instrumentations/web/page-view/test/pageView.test.ts index ece524ac9..f70941677 100644 --- a/pkgs/instrumentations/web/page-view/test/pageView.test.ts +++ b/pkgs/instrumentations/web/page-view/test/pageView.test.ts @@ -29,6 +29,7 @@ import { logs } from '@opentelemetry/sandbox-api-logs'; import { events } from '@opentelemetry/sandbox-api-events'; import { PageTypes } from '../src/enums/PageTypes'; + describe('PageView Instrumentation', () => { let plugin: PageViewEventInstrumentation; const sandbox = sinon.createSandbox(); @@ -42,7 +43,9 @@ describe('PageView Instrumentation', () => { events.setGlobalEventEmitterProvider(eventEmitterProvider); afterEach(() => { + console.log("Running afterEach"); exporter.reset(); + console.log("Records after reset: ", exporter.getFinishedLogRecords()); plugin.disable(); }); @@ -105,7 +108,6 @@ describe('PageView Instrumentation', () => { }); history.pushState({}, '', '/dummy1.html'); - assert.strictEqual(exporter.getFinishedLogRecords().length, 1); const pageViewLogRecord = @@ -234,7 +236,6 @@ describe('PageView Instrumentation', () => { (pageViewLogRecord2.attributes['event.data'])['referrer'], secondReferrer ); - done(); }); });