Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading Description of db.namespace in Documentation - References Server Address and Port #1321

Closed
agent-adam opened this issue Aug 6, 2024 · 2 comments
Labels

Comments

@agent-adam
Copy link

Area(s)

area:db

What happened?

Description

The documentation for the db.namespace attribute mentions "fully qualified within the server address and port." don't think the server address is or should be part of the database name.

Steps to Reproduce (if any)

Expected Result

Actual Result

Semantic convention version

1.27

Additional context

No response

@lmolkova
Copy link
Contributor

lmolkova commented Aug 6, 2024

The documentation for the db.namespace attribute mentions "fully qualified within the server address and port." don't think the server address is or should be part of the database name.

Thank you for reporting this! Could you please elaborate on what's misleading?

The intention is that db.namespace does not contain server.address|port, but uniquely identifies a database that's hosted there.

E.g. I can have mysql running on localhost:3306 and two databases user and orders there.
When connecting to/querying from users, it would result in the following attributes:

  • server.address = localhost
  • server.port = 3306
  • db.namespace = user

When querying from orders, it would result in

  • server.address = localhost
  • server.port = 3306
  • db.namespace = orders

@agent-adam
Copy link
Author

agent-adam commented Aug 7, 2024

Might just be a miss reading from my end. I see it means that it's the fully qualified name of the database within the context of that server and does not mean that it should include the server address and port values directly.

Thanks for the help here! closing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

3 participants