Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Database] db.operation.batch.size records number of queries #1353

Closed
lmolkova opened this issue Aug 19, 2024 · 1 comment · Fixed by #1448
Closed

[Database] db.operation.batch.size records number of queries #1353

lmolkova opened this issue Aug 19, 2024 · 1 comment · Fixed by #1448
Labels
area:db bug Something isn't working

Comments

@lmolkova
Copy link
Contributor

- id: db.operation.batch.size
type: int
stability: experimental
brief: The number of queries included in a [batch operation](/docs/database/database-spans.md#batch-operations).

Number of queries and number of records could be different. I think we can make attribute name more descriptive to reflect this.

  • If the intention is to record number of queries, we can do db.query.batch.size
  • to record number of items, we can use something like db.request.records.count or db.response.records.count

Also, it seems we have the attribute defined in the registry, but not referenced in the conventions - we should probably reference it.

@lmolkova
Copy link
Contributor Author

lmolkova commented Oct 3, 2024

From some past discussion in database WG:

I was confused with the naming db.operation.batch.size, but db.query.batch.size would be even more confusing. So taking this concern back.

The last concern remains - we forgot to add db.operation.batch.size into span attributes table and only have it in the registry - that's the only action item remaining in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:db bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants