Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the usage of db.operation.name #1365

Open
yordis opened this issue Aug 23, 2024 · 2 comments
Open

Clarify the usage of db.operation.name #1365

yordis opened this issue Aug 23, 2024 · 2 comments
Labels
area:db enhancement New feature or request

Comments

@yordis
Copy link

yordis commented Aug 23, 2024

Area(s)

area:db

Is your change request related to a problem? Please describe.

As per request from @trask from Slack:

There is confusion regarding the correct usage of db.operation.name in the OpenTelemetry database spans documentation.

The current examples and explanations suggest that db.operation.name should correspond to database-specific operations or commands (e.g., findAndModify), which has led to uncertainty among developers, including core maintainers, about whether this field can be used for the domain-specific language that is more relevant to the application context (e.g., fetchUserPreferences).

This ambiguity makes it difficult for users to identify the source of database calls in monitoring systems like CloudWatch, especially when SQL queries are too large or dynamic to be helpful in this context.

Describe the solution you'd like

The documentation should explicitly state that db.operation.name can be used as a free-form field specific to the application and not necessarily tied to database engine operations. It should clarify that developers can override the default names provided by instrumentation with more meaningful names that help identify the source of database calls within their domain.

Additionally, it would be beneficial to include examples demonstrating both database-specific and application-specific usages of db.operation.name, highlighting how it can be leveraged to improve traceability and monitoring.

Describe alternatives you've considered

No response

Additional context

No response

@yordis
Copy link
Author

yordis commented Sep 30, 2024

Hey @trask, any updates on this one?

@trask
Copy link
Member

trask commented Oct 2, 2024

I agree that users should be allowed to override db.operation.name with something that makes more sense in their context, but I think in practice this would require open-telemetry/oteps#207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:db enhancement New feature or request
Projects
Status: Post Stability
Development

No branches or pull requests

4 participants