Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should system metrics be renamed to os (for consistency with attributes)? #1371

Open
lmolkova opened this issue Aug 29, 2024 · 3 comments
Open

Comments

@lmolkova
Copy link
Contributor

We have os.name, os.version, type, etc attributes, but use system on metrics (system.cpu.time, system.memory.usage, etc).

System metrics are effectively OS metrics:

The `system.*` namespace SHOULD be exclusively used to report hosts' metrics.
The `system.*` namespace SHOULD only be used when the metrics are collected from within the target system. (physical servers, virtual machines etc).

We should consider renaming system to os (i.e. (os.cpu.time, ...) for the sake of consistency.

Also I'd expect system metrics to be reported with os resource (it's useful to know the OS type when interpreting specific metric), but it's not documented.

@heyams
Copy link
Contributor

heyams commented Aug 29, 2024

@lmolkova
Copy link
Contributor Author

check here: https://github.com/open-telemetry/semantic-conventions/blob/3146dc01dc4ab477549f51ceed3b8f8cb98b5829/specification/metrics/semantic_conventions/system-metrics.md#systemos---os-specific-system-metrics

I assume it could still be os.windows or os.linux instead of system.windows and os.linux. Or do I miss something?

@ChrsMark
Copy link
Member

We have os.name, os.version, type, etc attributes, but use system on metrics (system.cpu.time, system.memory.usage, etc).

Similarly we have host.* namespace which is not merged to the system.*. We had agreed as a WG group that host.* will be used for resource attributes of a system while the system.* namespace will be used for the metrics.

I assume the same applies for the os.* resource attributes which are separate and describe a distinct set of information.

We should consider renaming system to os (i.e. (os.cpu.time, ...) for the sake of consistency.

We would need some concrete use cases to change the current model which is widely used extensively by the Collector users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants