Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service.instance.pool #1404

Open
verdie-g opened this issue Sep 13, 2024 · 0 comments
Open

Add service.instance.pool #1404

verdie-g opened this issue Sep 13, 2024 · 0 comments
Assignees
Labels
area:service enhancement New feature or request experts needed This issue or pull request is outside an area where general approvers feel they can approve triage:needs-triage

Comments

@verdie-g
Copy link

verdie-g commented Sep 13, 2024

Area(s)

area:service

Is your change request related to a problem? Please describe.

Instances of a service can be grouped into pools. For example, a service could be split into two pools: canary and default. Canary being a small pool that is deployed before default to check that everything is working as expected. Some pools can also be test pools of one or two instances to test a change in production.

The metrics can be aggregated by pool to easily compare the canary and default pools but currently there is no standard labels for that concept.

Describe the solution you'd like

A new label service.instance.pool which designates the pool the instance is part of. The value would depend on the company but some recommended values would be:

  • default
  • canary
  • test-1
  • test-2

Describe alternatives you've considered

  • service.instance.pool.name in case a pool can have other fields, such as an id + name
  • service.pool but I think it makes more sense to add it at the instance level
  • deployment.pool

Additional context

No response

@verdie-g verdie-g added enhancement New feature or request experts needed This issue or pull request is outside an area where general approvers feel they can approve triage:needs-triage labels Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:service enhancement New feature or request experts needed This issue or pull request is outside an area where general approvers feel they can approve triage:needs-triage
Projects
None yet
Development

No branches or pull requests

2 participants