Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change prefix id of deprecated attributes #896

Closed
trisch-me opened this issue Apr 5, 2024 · 1 comment · Fixed by #898
Closed

Change prefix id of deprecated attributes #896

trisch-me opened this issue Apr 5, 2024 · 1 comment · Fixed by #898
Assignees
@joaopgrassi @trisch-me

Comments

@trisch-me
Copy link
Contributor

trisch-me commented Apr 5, 2024 •
edited
Loading

Currently we have for deprecated attributes different naming structure than for standard registry attributes:

attributes.container.deprecated
vs
registry.container.*

or
attributes.db.deprecated
vs
registry.db

In order to automate registry autogeneration I propose to use for deprecated attributes the same prefix, i.e.

normal attributes: registry.X.*
deprecated attributes: registry.X.deprecated.*

Please let me know if you see any issues with it
@trisch-me trisch-me self-assigned this Apr 5, 2024
@trisch-me
Copy link
Contributor Author

@jsuereth @lmolkova FYI

@trisch-me trisch-me mentioned this issue Apr 5, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joaopgrassi joaopgrassi

@trisch-me trisch-me

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore] change prefix for deprecated attributes trisch-me/semantic-conventions
2 participants
@joaopgrassi @trisch-me