From d2fb0703d50a4627951262f88f32df3648fe26f5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Franz=20P=C3=B6schel?= <franz.poeschel@gmail.com>
Date: Fri, 24 Nov 2023 13:37:12 +0100
Subject: [PATCH] Refactor `if` statement

---
 src/IO/JSON/JSONIOHandlerImpl.cpp | 104 +++++++++++++++---------------
 1 file changed, 52 insertions(+), 52 deletions(-)

diff --git a/src/IO/JSON/JSONIOHandlerImpl.cpp b/src/IO/JSON/JSONIOHandlerImpl.cpp
index 5518b1b98f..9910714c4b 100644
--- a/src/IO/JSON/JSONIOHandlerImpl.cpp
+++ b/src/IO/JSON/JSONIOHandlerImpl.cpp
@@ -1346,54 +1346,55 @@ auto JSONIOHandlerImpl::putJsonContents(
         filename.valid(),
         "[JSON] File has been overwritten/deleted before writing");
     auto it = m_jsonVals.find(filename);
-    if (it != m_jsonVals.end())
+    if (it == m_jsonVals.end())
     {
-        (*it->second)["platform_byte_widths"] = platformSpecifics();
+        return it;
+    }
 
-        auto writeSingleFile = [this, &it](std::string const &writeThisFile) {
-            auto [fh, _, fh_with_precision] =
-                getFilehandle(File(writeThisFile), Access::CREATE);
-            (void)_;
+    (*it->second)["platform_byte_widths"] = platformSpecifics();
 
-            switch (m_fileFormat)
-            {
-            case FileFormat::Json:
-                *fh_with_precision << *it->second << std::endl;
-                break;
-            case FileFormat::Toml:
-                *fh_with_precision << openPMD::json::jsonToToml(*it->second)
-                                   << std::endl;
-                break;
-            }
+    auto writeSingleFile = [this, &it](std::string const &writeThisFile) {
+        auto [fh, _, fh_with_precision] =
+            getFilehandle(File(writeThisFile), Access::CREATE);
+        (void)_;
 
-            VERIFY(fh->good(), "[JSON] Failed writing data to disk.")
-        };
+        switch (m_fileFormat)
+        {
+        case FileFormat::Json:
+            *fh_with_precision << *it->second << std::endl;
+            break;
+        case FileFormat::Toml:
+            *fh_with_precision << openPMD::json::jsonToToml(*it->second)
+                               << std::endl;
+            break;
+        }
 
-        auto serialImplementation = [&filename, &writeSingleFile]() {
-            writeSingleFile(*filename);
-        };
+        VERIFY(fh->good(), "[JSON] Failed writing data to disk.")
+    };
+
+    auto serialImplementation = [&filename, &writeSingleFile]() {
+        writeSingleFile(*filename);
+    };
 
 #if openPMD_HAVE_MPI
-        auto num_digits = [](unsigned n) -> unsigned {
-            constexpr auto max = std::numeric_limits<unsigned>::max();
-            unsigned base_10 = 1;
-            unsigned res = 1;
-            while (base_10 < max)
+    auto num_digits = [](unsigned n) -> unsigned {
+        constexpr auto max = std::numeric_limits<unsigned>::max();
+        unsigned base_10 = 1;
+        unsigned res = 1;
+        while (base_10 < max)
+        {
+            base_10 *= 10;
+            if (n / base_10 == 0)
             {
-                base_10 *= 10;
-                if (n / base_10 == 0)
-                {
-                    return res;
-                }
-                ++res;
+                return res;
             }
-            return res;
-        };
+            ++res;
+        }
+        return res;
+    };
 
-        auto parallelImplementation = [this,
-                                       &filename,
-                                       &writeSingleFile,
-                                       &num_digits](MPI_Comm comm) {
+    auto parallelImplementation =
+        [this, &filename, &writeSingleFile, &num_digits](MPI_Comm comm) {
             auto path = fullPath(*filename);
             auto dirpath = path + ".parallel";
             if (!auxiliary::create_directories(dirpath))
@@ -1453,23 +1454,22 @@ merge the .json files somehow (no tooling provided for this (yet)).
             }
         };
 
-        std::shared_ptr<nlohmann::json> res;
-        if (m_communicator.has_value())
-        {
-            parallelImplementation(m_communicator.value());
-        }
-        else
-        {
-            serialImplementation();
-        }
+    std::shared_ptr<nlohmann::json> res;
+    if (m_communicator.has_value())
+    {
+        parallelImplementation(m_communicator.value());
+    }
+    else
+    {
+        serialImplementation();
+    }
 
 #else
-        serialImplementation();
+    serialImplementation();
 #endif
-        if (unsetDirty)
-        {
-            m_dirty.erase(filename);
-        }
+    if (unsetDirty)
+    {
+        m_dirty.erase(filename);
     }
     return it;
 }