-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improper use of set_const
#1526
Comments
Apologies, I accidently created this issue here instead of on the fork, I didn't realize vscode would do it like that. |
@barche Thanks for the pointer! |
Quote from the other issue:
Feel free to leave this issue open since this change needs to be applied in both places. |
Corrected. |
https://github.com/eschnett/openPMD-api/blob/13ea8b4ecca968a5355825d639b3e9182d14b484/src/binding/julia/Datatype.cpp#L15
In the above line,
jlcxx::Module::set_const
is used on anstd::vector
. This was always something that was incompatible with Julia precompilation, and since libcxxwrap-julia 0.11 gives a compile error. A function returning the vector should be used instead.The text was updated successfully, but these errors were encountered: