Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper use of set_const #1526

Open
barche opened this issue Sep 5, 2023 · 4 comments
Open

Improper use of set_const #1526

barche opened this issue Sep 5, 2023 · 4 comments

Comments

@barche
Copy link

barche commented Sep 5, 2023

https://github.com/eschnett/openPMD-api/blob/13ea8b4ecca968a5355825d639b3e9182d14b484/src/binding/julia/Datatype.cpp#L15

In the above line, jlcxx::Module::set_const is used on an std::vector. This was always something that was incompatible with Julia precompilation, and since libcxxwrap-julia 0.11 gives a compile error. A function returning the vector should be used instead.

@barche
Copy link
Author

barche commented Sep 5, 2023

Apologies, I accidently created this issue here instead of on the fork, I didn't realize vscode would do it like that.

@eschnett
Copy link
Contributor

eschnett commented Sep 5, 2023

@barche Thanks for the pointer!

@franzpoeschel
Copy link
Contributor

Quote from the other issue:

You're probably noticing a slight breaking change that we did on openPMD_datatypes. We had linker trouble with the constant and since it's a barely-used API, we replaced it with a function.
So, yeah, the Julia bindings will need to adapt to this. (This situation is one of the reasons why I'm in favor of trying to go for a single repo in the end)

Feel free to leave this issue open since this change needs to be applied in both places.

@eschnett
Copy link
Contributor

eschnett commented Sep 5, 2023

Corrected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants