Extend comment validation for invalid xml characters (closes #16302) #16304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frozenIceage
force-pushed
the
issue_16302
branch
from
da0b7ea
to
dc3435f
Compare
|
The minitest tests are failing, if you need help, just say it... |
hellcp-work
reviewed
Jun 11, 2024
| @@ -8,8 +8,8 @@ class Comment < ApplicationRecord | |||
| validates :body, presence: true | |||
| # FIXME: this probably should be MEDIUMTEXT(16MB) instead of text (64KB) | |||
| validates :body, length: { maximum: 65_535 } | |||
| validates :body, format: { with: /\A[^\u0000]*\Z/, | |||
| message: 'must not contain null characters' } | |||
| validates :body, format: { with: /\A[\u0009\u000A\u000D\u0020-\uD7FF\uE000-\uFFFD\u{10000}-\u{10FFFF}]*\Z/, | |||
There was a problem hiding this comment.
This doesn't exactly fix the existing data, is there no way to escape these characters when rendering xmls?
Thanks! Need some time to set up my local development environment first, let me close it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16302