-
Notifications
You must be signed in to change notification settings - Fork 7.5k
fix: handle utf-8 in windows sandbox logs #8647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: handle utf-8 in windows sandbox logs #8647
Conversation
Avoid panicking when the command preview truncates multi-byte characters. Use a char-boundary truncation helper and add a regression test.
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
@davidgilbertson, thanks for the contribution. I'm a bit confused by the commit comment. You mention that this fix relates to |
|
Sure, it's a long and winding road from In Apply patch tool handler: In Apply patch runtime: In Sandbox execution pipeline: In Windows sandbox entry: In Windows sandbox logging: both the non‑elevated and elevated |
|
Has this fallen through the cracks? |
|
@davidgilbertson, it's in the queue for review. Apologies for the slow response. The Codex Team has been very busy lately. |
Currently
apply_patchwill fail on Windows if the file contents happen to have a multi-byte character at the point where thepreviewfunction truncates.I've used the existing
take_bytes_at_char_boundaryhelper and added a regression test (that fails without the fix).This is related to #4013 but doesn't fix it.