Add WebSocket custom options to OpenAIRealtimeWebSocketModel #2264
Conversation
|
@seratch, can you please review this ? thx |
seratch
changed the title
seratch
left a comment
seratch
left a comment
There was a problem hiding this comment.
can you add unit tests for covering the scenario?
src/agents/realtime/model.py
Outdated
| pass | ||
|
|
||
|
|
||
| class TransportConfig(TypedDict): |
There was a problem hiding this comment.
these properties are websockets library specific, so I am thinking of a better naming. I am focusing on other stuff (especially making the HITL successful) so let me hold off deciding details here for now
There was a problem hiding this comment.
Understood, waiting for it. One note, these are fairly common concepts that also exist in other WebSocket libraries, as keeping alive through pings is a WebSocket standard.
There was a problem hiding this comment.
@seratch, can you please look at the PR and make it progress? There should not be much work left to be done here.
@seratch I have added the unit tests covering the changes to the related parameters. Please review. |
|
@seratch I have added test suites that support the cases and also test the parameter updates. |
seratch
changed the title
|
@seratch applied your comments, please take a look |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f7c27b4375
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
2 participants
This PR provides web socket connection configurability for the real-time bot communication. Fixes the enhancement request #2234 i have issued