From bd9fad25c2646707c2a0fe8601bbd362610d0d9d Mon Sep 17 00:00:00 2001 From: Andres Suarez Date: Fri, 13 Aug 2021 09:26:38 -0700 Subject: [PATCH] [codemod][lint][caffe2] Extend BLACK coverage Test Plan: Sandcastle Reviewed By: zsol Differential Revision: D30302716 fbshipit-source-id: f9724d4f4d1b8950f581cc2c6c77eedf19b4b6fc --- .../package/tool/parser/gcov_coverage_parser.py | 12 ++++++------ .../package/tool/parser/llvm_coverage_parser.py | 14 +++++++------- .../package/tool/parser/llvm_coverage_segment.py | 4 ++-- tools/code_coverage/package/util/utils.py | 4 +++- 4 files changed, 18 insertions(+), 16 deletions(-) diff --git a/tools/code_coverage/package/tool/parser/gcov_coverage_parser.py b/tools/code_coverage/package/tool/parser/gcov_coverage_parser.py index 4d06cce1f9537..000b72cbc2d80 100644 --- a/tools/code_coverage/package/tool/parser/gcov_coverage_parser.py +++ b/tools/code_coverage/package/tool/parser/gcov_coverage_parser.py @@ -5,9 +5,9 @@ class GcovCoverageParser: """ - Accepts a parsed json produced by gcov --json-format -- typically, - representing a single C++ test and produces a list - of CoverageRecord(s). + Accepts a parsed json produced by gcov --json-format -- typically, + representing a single C++ test and produces a list + of CoverageRecord(s). """ def __init__(self, llvm_coverage: Dict[str, Any]) -> None: @@ -16,9 +16,9 @@ def __init__(self, llvm_coverage: Dict[str, Any]) -> None: @staticmethod def _skip_coverage(path: str) -> bool: """ - Returns True if file path should not be processed. - This is repo-specific and only makes sense for the current state of - ovrsource. + Returns True if file path should not be processed. + This is repo-specific and only makes sense for the current state of + ovrsource. """ if "third-party" in path: return True diff --git a/tools/code_coverage/package/tool/parser/llvm_coverage_parser.py b/tools/code_coverage/package/tool/parser/llvm_coverage_parser.py index 8d0cc21d1f550..691bb40a2a2b5 100644 --- a/tools/code_coverage/package/tool/parser/llvm_coverage_parser.py +++ b/tools/code_coverage/package/tool/parser/llvm_coverage_parser.py @@ -6,9 +6,9 @@ class LlvmCoverageParser: """ - Accepts a parsed json produced by llvm-cov export -- typically, - representing a single C++ test and produces a list - of CoverageRecord(s). + Accepts a parsed json produced by llvm-cov export -- typically, + representing a single C++ test and produces a list + of CoverageRecord(s). """ @@ -18,9 +18,9 @@ def __init__(self, llvm_coverage: Dict[str, Any]) -> None: @staticmethod def _skip_coverage(path: str) -> bool: """ - Returns True if file path should not be processed. - This is repo-specific and only makes sense for the current state of - ovrsource. + Returns True if file path should not be processed. + This is repo-specific and only makes sense for the current state of + ovrsource. """ if "/third-party/" in path: return True @@ -31,7 +31,7 @@ def _collect_coverage( segments: List[LlvmCoverageSegment], ) -> Tuple[List[int], List[int]]: """ - Stateful parsing of coverage segments. + Stateful parsing of coverage segments. """ covered_lines: Set[int] = set() uncovered_lines: Set[int] = set() diff --git a/tools/code_coverage/package/tool/parser/llvm_coverage_segment.py b/tools/code_coverage/package/tool/parser/llvm_coverage_segment.py index 17d7c18975ff9..6f780c1e0f824 100644 --- a/tools/code_coverage/package/tool/parser/llvm_coverage_segment.py +++ b/tools/code_coverage/package/tool/parser/llvm_coverage_segment.py @@ -34,8 +34,8 @@ def get_coverage( def parse_segments(raw_segments: List[List[int]]) -> List[LlvmCoverageSegment]: """ - Creates LlvmCoverageSegment from a list of lists in llvm export json. - each segment is represented by 5-element array. + Creates LlvmCoverageSegment from a list of lists in llvm export json. + each segment is represented by 5-element array. """ ret: List[LlvmCoverageSegment] = [] for raw_segment in raw_segments: diff --git a/tools/code_coverage/package/util/utils.py b/tools/code_coverage/package/util/utils.py index 06a6ba0a72c51..6133c35dd8338 100644 --- a/tools/code_coverage/package/util/utils.py +++ b/tools/code_coverage/package/util/utils.py @@ -138,7 +138,9 @@ def check_test_type(test_type: str, target: str) -> None: ) -def raise_no_test_found_exception(cpp_binary_folder: str, python_binary_folder: str) -> NoReturn: +def raise_no_test_found_exception( + cpp_binary_folder: str, python_binary_folder: str +) -> NoReturn: raise RuntimeError( f"No cpp and python tests found in folder **{cpp_binary_folder} and **{python_binary_folder}**" )