telephone call not displaying the other persons room

[WizzardMaker]

When calling someone, the other room is usually displayed. This is no longer the case in the new SDL build

How it's supposed to look like:

[dedmen]

in SDL_UpperBlit (SDL_surface.c)
after destiantion clip the width is -160 and the height is 440.

Destination rect x is 800, but destination clip is only 640 wide.
Thus is just skips the whole blit.

But, even fixing that doesn't fix it.

[dedmen]

Found it.

SDL_SaveBMP(qRoom.RoomBm.pBitmap->GetSurface(), "P:\\oroom.bmp");
SDL_SaveBMP(RoomBm.pBitmap->GetSurface(), "P:\\preblit.bmp");
RoomBm.BlitFrom (qRoom.RoomBm, &SrcRect, Dest);
SDL_SaveBMP(RoomBm.pBitmap->GetSurface(), "P:\\postblit.bmp");

If you dump the rooms. The other room thats blitted in is just black texture. It hasn't been rendered

[dedmen]

CStdRaum::OnPaint(BOOL bHandyDialog)
I'd assume that bHandyDialog flag for painting is there for a reason.. well it once was maybe

Think is, GameFrame::Invalidate renders only location windows of the players.
So dialog room is never pained.

I just did

          if (Sim.Players.Players[c].DialogWin)
              Sim.Players.Players[c].DialogWin->OnPaint(true);

         w = Sim.Players.Players[c].LocationWin;

in GameFrame::Invalidate, so we paint the dialog room before we render the players room

Well... its something?

[dedmen]

Can also call qRoom.OnPaint(true) from within CStdRaum::PostPaint, so we render it just before we want to blit it in.

But that doesn't make a difference, character is still missing and the blit artifacts at the bottom.

Ah because it calls CStdRaum::OnPaint, instead of the overrridden CAufsicht::OnPaint()
Cannot call with true :D

So just qRoom.OnPaint();

Bam!

[dedmen]

Oops, wrong direction

Tada

Had to turn color key off
Color key seems to be new with SDL2, but that doesn't explain why the other room was not pained.

in CStdRaum::PostPaint()

      CStdRaum &qRoom=*(CStdRaum*)qPlayer.DialogWin;
      SDL_SetColorKey(qRoom.RoomBm.pBitmap->GetSurface(), false, 0);
      qRoom.OnPaint();
      CRect     SrcRect (qRoom.HandyOffset, 0, qRoom.HandyOffset+340, 440);
      XY        Dest (qRoom.TempScreenScroll, 0);

It seems like a very hacky solution though.

[dedmen]

Ah I guess CWnd from MFC automatically always paints itself.
So previously all instanciated rooms would've always been painted?

https://docs.microsoft.com/en-us/cpp/mfc/reference/cwnd-class?view=msvc-170#onpaint
Yeah seems like it.

Yes every room called in its constructor

   ShowWindow(SW_SHOW);
   UpdateWindow();

That would paint the room once immediately after its constructed.
And its then a active window, so it would be painted regularly?