Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES] No suggestion when using opening exclamation/question mark #667

Closed
ElSebita opened this issue Aug 13, 2022 · 6 comments · May be fixed by #694
Closed

[ES] No suggestion when using opening exclamation/question mark #667

ElSebita opened this issue Aug 13, 2022 · 6 comments · May be fixed by #694
Labels
bug Something isn't working

Comments

@ElSebita
Copy link

Describe the bug
In Spanish there are opening symbols to mark a question or an exclamation. "¿Dónde vas?"
After typing the opening mark, keyboard doesn't suggest any word. Tapping backspace activates the suggestion, though.

To Reproduce
Steps to reproduce the behavior:

  1. Use Spanish
  2. Tap an opening exclamation or question mark ¿ ¡
  3. Start typing
  4. There are no suggestions or corrections

Expected behavior
Whenever keyboard detects an opening mark in Spanish, suggestion should be active again since it's a grammar rule, not a special word.

Screenshots
Screenshot_20220812-211804_GitHub.png

Smartphone (please complete the following information):

  • Device: Xiaomi Mi 9 (cepheus)
  • OS: Android 12.1

Additional context
Nothing to note

@ElSebita ElSebita added the bug Something isn't working label Aug 13, 2022
@Helium314
Copy link
Contributor

I only did a very quick test, and adding ¿¡ to symbols_word_connectors for es appears to help.
But lacking Spanish language skills I can't test properly and tell whether it may have unintended side effects, as isWordConnector is checked in many places.

@ElSebita
Copy link
Author

Tell me what to do, what tests you need, and I can do it.

@Helium314
Copy link
Contributor

All I did was adding a file donottranslate-config-spacing-and-punctuations.xml to app/src/main/res/values-es with content

<?xml version="1.0" encoding="utf-8"?>
<resources xmlns:xliff="urn:oasis:names:tc:xliff:document:1.2">
    <string name="symbols_word_connectors">\'-¡¿</string>
</resources>

Can you compile the app yourself? If not I can upload an APK.

@ElSebita
Copy link
Author

I never compiled an APK before 😅

@Helium314
Copy link
Contributor

Hm, I did some more test and noticed that if you tap the word after it's written, OpenBoard with my modification will show ¿Donde as center suggestion, while it should obviously be Donde...
So only while you write it looks good, but my initial approach definitely was not a solution.

Anyway, when adding ¿¡ to symbols_word_separators instead of symbols_word_connectors it appears to work.

APK (zipped because GitHub doesn't allow attaching APK): openboard_es_fix.zip
Note that you will have to uninstall OpenBoard, because the signing key does not match. If possible you should back up the original app before you try this version, so you don't lose your settings and typed word history (personal dictionary is safe).

@ElSebita
Copy link
Author

Working like a charm so far

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants