Skip to content

Commit ff2a4c1

Browse files
committed
chore: more general dx updates and some css
1 parent 30af262 commit ff2a4c1

File tree

6 files changed

+50
-16
lines changed

6 files changed

+50
-16
lines changed

.eslintrc

+7-6
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,19 @@
11
{
2-
"extends": ["react-app"],
2+
"extends": ["plugin:react-hooks/recommended", "react-app"],
33
"rules": {
44
"array-bracket-spacing": "error",
55
"comma-spacing": "error",
6-
"indent": ["error", 2, { "SwitchCase": 1, "ignoreComments": true }],
7-
"keyword-spacing": ["error", { "before": true, "after": true }],
6+
"indent": ["warn", 2, { "ignoreComments": true, "SwitchCase": 1, "CallExpression": { "arguments": 1 } }],
7+
"keyword-spacing": ["error", { "after": true, "before": true }],
88
"new-cap": "error",
99
"no-multi-spaces": ["error", { "ignoreEOLComments": true }],
1010
"no-redeclare": ["error", { "builtinGlobals": true }],
11+
"no-unused-vars": ["warn", { "argsIgnorePattern": "^_", "caughtErrorsIgnorePattern": "^_", "varsIgnorePattern": "^_" }],
1112
"object-curly-spacing": ["error", "always"],
12-
"quotes": ["error", "single", { "avoidEscape": true, "allowTemplateLiterals": true }],
13+
"quotes": ["error", "single", { "allowTemplateLiterals": true, "avoidEscape": true }],
1314
"semi": ["error", "always"],
14-
"space-before-function-paren": ["error", { "anonymous": "never", "named": "never", "asyncArrow": "always" }],
15-
"space-in-parens": ["error"],
15+
"space-before-function-paren": ["error", { "anonymous": "never", "asyncArrow": "always", "named": "never" }],
16+
"space-in-parens": "error",
1617
"space-infix-ops": "error"
1718
}
1819
}

TODO.md

+8
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
2+
- [x] Stop spamming Google Books. Rebounce and maybe get an actual API_KEY
3+
- [ ] Update to newest react-router version
4+
- [ ] Eject create-react-app
5+
- [ ] Move styling to `styled-components`
6+
- [ ] Allow voters to add a password
7+
- [ ] Consolidate input styling. Placeholder floats to label.
8+
- [ ] Allow users to provide their own Google Books API key (byoapik)

package-lock.json

+31-8
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@
1515
},
1616
"devDependencies": {
1717
"@types/react-router-dom": "^5.3.3",
18-
"chokidar": "^3.5.2"
18+
"chokidar": "^3.5.2",
19+
"eslint-plugin-react-hooks": "^5.0.0"
1920
},
2021
"scripts": {
2122
"start": "react-scripts start",

src/app/Footer.css

+1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
margin-bottom: 1rem;
99
margin-top: auto;
1010
padding: 0;
11+
padding-top: 1rem;
1112
}
1213

1314
.Footer a {

src/styles/_normalize.css

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ html {
2828
'Segoe UI Emoji';
2929
line-height: 1.15; /* 1. Correct the line height in all browsers. */
3030
-webkit-text-size-adjust: 100%; /* 2. Prevent adjustments of font size after orientation changes in iOS. */
31-
tab-size: 4; /* 3. Use a more readable tab size (opinionated). */
31+
tab-size: 2; /* 3. Use a more readable tab size (opinionated). */
3232
}
3333

3434
/*

0 commit comments

Comments
 (0)