GPX import does not support attributes

[stefopl]

A user preparing multiple caches for a GeoPath noticed that attributes (like "magnetic") are not imported from GPX files. It was confirmed by exporting a GPX from an existing cache with attributes and re-importing it, attributes were ignored.

@rapotek Would it be possible to add support for importing attributes from GPX files?

[rapotek]

Attributes import from GPX was never supported, otherwise I would implement it in the first PR commits regarding importing issue. I would look at it, but it may be not trivial because of differences between OC and GC attributes.

[andrixnet]

There is a huge logistic behind such a feature.
Remember, OC attributes are not 1:1 compatible with GC attributes.
Also, different OC sites (even those based on opencaching-pl project) have different sets of attributes (only partially overlapping).
To my knowledge, at this time only OKAPI makes a reasonable correspondance, mostly from OC attributes to OC-specific and GC-compatbile. It's very good, though I'm not sure if that is 100% accurate at this time.

Back when covid started with quarantine and such, I was working on a complete attribute overhaul that whould have made a lot more sense and made conversions and compatibilities much easier to handle. Unfortunately covid situation prevented me from finishing this task and I haven't been able to resume it since :-( . Though still on my TODO list.

[rapotek]

I think, I could implement support for importing attributes exported by our GPX export on the geocache page, but I have a problem: attributes are saved in database using identifiers read from table cache_attrib. There is a hardcoded mapping in lib/format.gpx.inc.php of these identifiers to GPX export entries, but it uses identifiers like 202, 204 etc. My development database has corresponding identifiers like 4202, 1204, so it looks like I have an outdated version. Could someone pass here a valid data for this table? There are no sensitive or huge amount of data in this table, so it shouldn't be a legal or technical problem.

[andrixnet]

Documentation here https://wiki.opencaching.eu/index.php?title=Cache_attributes should cover it.

When I last worked on it, I compiled an as complete list of attributes as I was able to at the time.
To my knowledge, at least at opencaching-pl there were no attribute changes, or at least not documented ones.
I can't speak for OCDE, I haven't checked their code recently.
AFAIK there are some attribute changes at GC, I'll look into the GCTour userscript, AFAIK it should have an up to date implementation. (I inspired myself from it when I compiled the document)
lib/format.gpx.inc.pgp could use a bit of update as well, not all attribs from the documentation are in it.

The primary purpose of the document is ... to properly document the attributes.
While working on it I tried to make sure OCDE and OCPL attributes do not overlap (regarding IDs).

Also, to my knowledge, most if not 100% of OKAPI attribute handling corresponds to the documentation.

OCRO, OCNL, OCUS I can confirm that they correspond 100% to the documentation regarding cache_attrib table.

P.S. with all this in mind, I am sure you can understand why moving attribute implementation to the code is both a desired thing and a huge and complex task. You must know that my work on attributes and their IDs was not finished, so if anyone wants to takle the task of implementing in the code, we must work together.

[rapotek]

@andrixnet Thanks for the link, I will update my db according to it. I found my old archive from 2017 and there identifiers in cache_attrib have another values, different from my db and your documentation (ranging from 40 to 90). There must have been some changes I missed.

I do not intend to work on adaptation and unification of attributes, it is a concept work outside my scope. I only would like to address the problem in OP above.

[stefopl]

Thanks @rapotek for adding attribute import support in #2508. I’ll notify the user that it’s now working.
In my OCPL database from around 2021, the cache_attrib table looks like this:

+-----+----------+----------------------+-------------------------------------------------+---------------------------------+------------------------------------+---------------------------------------+----------+---------+
| id  | language | text_short           | text_long                                       | icon_large                      | icon_no                            | icon_undef                            | category | default |
+-----+----------+----------------------+-------------------------------------------------+---------------------------------+------------------------------------+---------------------------------------+----------+---------+
|   2 | PL       | Okresowa/Płatna      | Dostępna w określonych godzinach lub płatna     | images/attributes/period.png    | images/attributes/period-no.png    | images/attributes/period-undef.png    |        1 |       0 |
|   2 | EN       | Periodical/Paid      | Periodical/Paid                                 | images/attributes/period.png    | images/attributes/period-no.png    | images/attributes/period-undef.png    |        1 |       0 |
|   4 | PL       | Wymagana łódź        | Dostępna tylko łodzią                           | images/attributes/boat.png      | images/attributes/boat-no.png      | images/attributes/boat-undef.png      |        1 |       0 |
|   4 | EN       | Boat                 | Boat                                            | images/attributes/boat.png      | images/attributes/boat-no.png      | images/attributes/boat-undef.png      |        1 |       0 |
|   6 | EN       | Children             | Go geocaching with children                     | images/attributes/children.png  | images/attributes/children-no.png  | images/attributes/children-undef.png  |        1 |       0 |
|   6 | PL       | Dzieci               | Można zabrać dzieci                             | images/attributes/children.png  | images/attributes/children-no.png  | images/attributes/children-undef.png  |        1 |       0 |
|  14 | PL       | Zalecane szukanie no | Zalecane szukanie nocą                          | images/attributes/night.png     | images/attributes/night-no.png     | images/attributes/night-undef.png     |        1 |       0 |
|  14 | EN       | Recommended at night | Recommended at night                            | images/attributes/night.png     | images/attributes/night-no.png     | images/attributes/night-undef.png     |        1 |       0 |
|  23 | PL       | Niebezpieczeństwo    | Skrzynka niebezpieczna                          | images/attributes/danger.png    | images/attributes/danger-no.png    | images/attributes/danger-undef.png    |        1 |       0 |
|  23 | EN       | Danger               | Dangerous Cache                                 | images/attributes/danger.png    | images/attributes/danger-no.png    | images/attributes/danger-undef.png    |        1 |       0 |
|  24 | PL       | Niepelnosprawni      | Dostępna dla niepełnosprawnych                  | images/attributes/disabled.png  | images/attributes/disabled-no.png  | images/attributes/disabled-undef.png  |        1 |       0 |
|  24 | EN       | for disabled         | Accessible for disabled                         | images/attributes/disabled.png  | images/attributes/disabled-no.png  | images/attributes/disabled-undef.png  |        1 |       0 |
|  32 | PL       | Dostępna rowerem     | Dostępna rowerem                                | images/attributes/bike.png      | images/attributes/bike-no.png      | images/attributes/bike-undef.png      |        1 |       0 |
|  32 | EN       | Bike                 | Bike                                            | images/attributes/bike.png      | images/attributes/bike-no.png      | images/attributes/bike-undef.png      |        1 |       0 |
|  44 | PL       | Latarka              | Potrzebna latarka                               | images/attributes/torch.png     | images/attributes/torch-no.png     | images/attributes/torch-undef.png     |        1 |       0 |
|  44 | EN       | Torch                | Torch needed                                    | images/attributes/torch.png     | images/attributes/torch-no.png     | images/attributes/torch-undef.png     |        1 |       0 |
|  51 | PL       | Sprzęt               | Wymagany dodatkowy sprzęt                       | images/attributes/equip.png     | images/attributes/equip-no.png     | images/attributes/equip-undef.png     |        1 |       0 |
|  51 | EN       | Equipment            | Take special equipment                          | images/attributes/equip.png     | images/attributes/equip-no.png     | images/attributes/equip-undef.png     |        1 |       0 |
|  60 | PL       | Beacon               | Beacon - Garmin chirp                           | images/attributes/beacon.png    | images/attributes/beacon-no.png    | images/attributes/beacon-undef.png    |        1 |       0 |
|  60 | EN       | Beacon               | Beacon - Garmin chirp                           | images/attributes/beacon.png    | images/attributes/beacon-no.png    | images/attributes/beacon-undef.png    |        1 |       0 |
| 108 | PL       | Letterbox            | Letterbox                                       | images/attributes/letterbox.png | images/attributes/letterbox-no.png | images/attributes/letterbox-undef.png |        1 |       0 |
| 108 | EN       | Letterbox            | Letterbox                                       | images/attributes/letterbox.png | images/attributes/letterbox-no.png | images/attributes/letterbox-undef.png |        1 |       0 |
| 147 | PL       | Potrzebny kompas     | Potrzebny kompas                                | images/attributes/compass.png   | images/attributes/compass-no.png   | images/attributes/compass-undef.png   |        1 |       0 |
| 147 | EN       | Compass              | Compass                                         | images/attributes/compass.png   | images/attributes/compass-no.png   | images/attributes/compass-undef.png   |        1 |       0 |
| 201 | PL       | Szybka skrzynka      | Szybka skrzynka                                 | images/attributes/quick.png     | images/attributes/quick-no.png     | images/attributes/quick-undef.png     |        1 |       0 |
| 201 | EN       | One-minute cache     | One-minute cache                                | images/attributes/quick.png     | images/attributes/quick-no.png     | images/attributes/quick-undef.png     |        1 |       0 |
| 202 | PL       | GeoHotel             | GeoHotel                                        | images/attributes/geohotel.png  | images/attributes/geohotel-no.png  | images/attributes/geohotel-undef.png  |        1 |       0 |
| 202 | EN       | GeoHotel             | GeoHotel                                        | images/attributes/geohotel.png  | images/attributes/geohotel-no.png  | images/attributes/geohotel-undef.png  |        1 |       0 |
| 203 | PL       | Weź coś do pisania   | Weź coś do pisania                              | images/attributes/pencil.png    | images/attributes/pencil-no.png    | images/attributes/pencil-undef.png    |        1 |       0 |
| 203 | EN       | Take something to wr | Take something to write                         | images/attributes/pencil.png    | images/attributes/pencil-no.png    | images/attributes/pencil-undef.png    |        1 |       0 |
| 204 | PL       | Magnes               | Przyczepiona magnesem                           | images/attributes/magnet.png    | images/attributes/magnet-no.png    | images/attributes/magnet-undef.png    |        1 |       0 |
| 204 | EN       | Magnet               | Fixed by magnet                                 | images/attributes/magnet.png    | images/attributes/magnet-no.png    | images/attributes/magnet-undef.png    |        1 |       0 |
| 205 | PL       | Informacje MP3       | Informacje zapisane w MP3                       | images/attributes/mp3.png       | images/attributes/mp3-no.png       | images/attributes/mp3-undef.png       |        1 |       0 |
| 205 | EN       | Information in MP3   | Information in  MP3 file                        | images/attributes/mp3.png       | images/attributes/mp3-no.png       | images/attributes/mp3-undef.png       |        1 |       0 |
| 206 | PL       | Offset cache         | Offset cache                                    | images/attributes/offset.png    | images/attributes/offset-no.png    | images/attributes/offset-undef.png    |        1 |       0 |
| 206 | EN       | Offset cache         | Offset cache                                    | images/attributes/offset.png    | images/attributes/offset-no.png    | images/attributes/offset-undef.png    |        1 |       0 |
| 207 | PL       | Dead Drop USB        | Dead Drop USB skrzynka                          | images/attributes/deaddrop.png  | images/attributes/deaddrop-no.png  | images/attributes/deaddrop-undef.png  |        1 |       0 |
| 207 | EN       | Dead Drop USB        | Dead Drop USB cache                             | images/attributes/deaddrop.png  | images/attributes/deaddrop-no.png  | images/attributes/deaddrop-undef.png  |        1 |       0 |
| 208 | EN       | Benchmark            | Benchmark - geodetict point                     | images/attributes/benchmark.png | images/attributes/benchmark-no.png | images/attributes/benchmark-undef.png |        1 |       0 |
| 208 | PL       | Punkt geodezyjny     | Benchmark - punkt geodezyjny                    | images/attributes/benchmark.png | images/attributes/benchmark-no.png | images/attributes/benchmark-undef.png |        1 |       0 |
| 209 | PL       | Scenariusz WIGO      | Scenariusz WIGO                                 | images/attributes/wigo.png      | images/attributes/wigo-no.png      | images/attributes/wigo-undef.png      |        1 |       0 |
| 209 | EN       | Cartridge            | Cartridge                                       | images/attributes/wigo.png      | images/attributes/wigo-no.png      | images/attributes/wigo-undef.png      |        1 |       0 |
| 210 | PL       | Natura               | Umiejscowiona na łonie natury, lasy, góry itp   | images/attributes/nature.png    | images/attributes/nature-no.png    | images/attributes/nature-undef.png    |        1 |       0 |
| 210 | EN       | Nature               | Nature                                          | images/attributes/nature.png    | images/attributes/nature-no.png    | images/attributes/nature-undef.png    |        1 |       0 |
| 211 | PL       | Historyczna          | Miejsce historyczne                             | images/attributes/monument.png  | images/attributes/monument-no.png  | images/attributes/monument-undef.png  |        1 |       0 |
| 211 | EN       | Monumental           | Monumental place                                | images/attributes/monument.png  | images/attributes/monument-no.png  | images/attributes/monument-undef.png  |        1 |       0 |
| 212 | PL       | Łopatka              | Potrzebna łopatka                               | images/attributes/dig.png       | images/attributes/dig-no.png       | images/attributes/dig-undef.png       |        1 |       0 |
| 212 | EN       | Shovel               | You will need a shovel                          | images/attributes/dig.png       | images/attributes/dig-no.png       | images/attributes/dig-undef.png       |        1 |       0 |
| 213 | PL       | Dostępna pieszo      | Dostępna tylko pieszo                           | images/attributes/walk.png      | images/attributes/walk-no.png      | images/attributes/walk-undef.png      |        1 |       0 |
| 213 | EN       | Access via walk      | Access only by walk                             | images/attributes/walk.png      | images/attributes/walk-no.png      | images/attributes/walk-undef.png      |        1 |       0 |
+-----+----------+----------------------+-------------------------------------------------+---------------------------------+------------------------------------+---------------------------------------+----------+---------+

[rapotek]

@stefopl Thanks for table contents, I have checked it out and mine is now the same. And thanks for correcting English translation.

Regarding cache attributes: if we are sure that for each attribute in the table there is always an English translation, I recommend to:

• change CacheAttribute class to DB object,
• add a method retrieving list of currently supported attribute IDs basing on EN language (I suggest a static one, initialized once or something similar),
• wherever we find in the code a select from cache_attrib with IDs and translation - replace it with the method call and, using already defined method, tr keys based on IDs.

This will allow translations to become independent from database content.

[andrixnet]

My suggestions is a complete attribute implementation in the code based on https://wiki.opencaching.eu/index.php?title=Cache_attributes

Since each OC site has it's own list of attributes, write a /config/attrib.pl.php /config/attrib.nl.php /config/attrib.uk.php to define which of the available attributes are actually valid for use on that site.
A default could be all attributes and likely this doesn't need a /config/attrib.default.php

[rapotek]

@andrixnet This would be ideal, moving site-dependant attribute list out of database, however there is one BUT to check before: does OKAPI use cache_attrib table? If so, moving config out of database could lead to inconsistencies.

[andrixnet]

@rapotek like I said before, this is a large and complex project.
Yes, OKAPI indeed uses cache_attrib table, it has to. So while implementing this, care must be taken to synchronize OKAPI with the changes in a compatible way across OCPL and OCDE based sites.

At least:
/okapi/services/attrs/attributes/WebService.php
/okapi/view/devel/attrlist/View.php

IIRC github had a projects section together with issues, so that it can be managed with more granular issues, to the scale of this undertaking.

Some years ago there were several such "projects" defined, one of them pertaining to OCNA migration, but since them they had dissapeared.

[stefopl]

https://www.opencaching.us
newcache.php
Exception: [src/Models/GeoCache/CacheAttribute.php:380] Attribute is not defined: 71
#0 /newcache.php(425): src\Models\GeoCache\CacheAttribute::getTrKey()

[andrixnet]

One more reason to implement the entire attribute set in the code and specify active attributes as config, instead of having divergent definition data in the database.

[stefopl]

https://www.opencaching.us newcache.php Wyjątek: [src/Models/GeoCache/CacheAttribute.php:380] Atrybut nie jest zdefiniowany: 71 #0 /newcache.php(425): src\Models\GeoCache\CacheAttribute::getTrKey()

Thanks to @rapotek, PR #2542 resolved the issue I mentioned above.