After updating to ILIAS 9 Opencast objects do not work if stream security is enabled

[DZenker]

Describe the bug
We've just updated our ILIAS to ILIAS 9, but the Opencast repo objects and page content don't work anymore if stream security is enabled.

Log
TypeError thrown with message "xoctSecureLink::sign(): Argument #3 ($restict_ip) must be of type ?bool, string given, called in /srv/www/ilias7.hs-fresenius.de/ilias/Customizing/global/plugins/Services/Repository/RepositoryObject/OpenCast/classes/class.xoctSecureLink.php on line 61"

Stacktrace:
#22 TypeError in /srv/www/ilias7.hs-fresenius.de/ilias/Customizing/global/plugins/Services/Repository/RepositoryObject/OpenCast/classes/class.xoctSecureLink.php:25
#21 xoctSecureLink:sign in /srv/www/ilias7.hs-fresenius.de/ilias/Customizing/global/plugins/Services/Repository/RepositoryObject/OpenCast/classes/class.xoctSecureLink.php:61
...

Environment (please complete the following information):

• ILIAS version: 9.7
• PHP version: 8.2.27
• Plugin version: 9.0.2
• Opencast version: 16.9
• Browser: all

e6u9i_8911.log

[DZenker]

Additional info: if the option "sign thumbnail link" is deactivated, it's working again. But, of course, no thumbnails show up anymore in the Opencast object...

[reiferschris]

Not sure what the intention in the code was, but it's weird. In https://github.com/opencast-ilias/OpenCast/blob/release_9/src/Util/Player/StandardPlayerDataBuilder.php#L306 there is already a check if the config option is enabled so removing it in xoctSecureLink should be fine from what I understand.

Does it work if you change:
https://github.com/opencast-ilias/OpenCast/blob/release_9/classes/class.xoctSecureLink.php#L25 to
protected static function sign(string $url, ?string $valid_until = null, ?string $restict_ip = null)

and
https://github.com/opencast-ilias/OpenCast/blob/release_9/classes/class.xoctSecureLink.php#L69 to
return self::sign($url, $valid_until);
?

[chfsx]

PR with fix: #413