Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rollup-preserve-directives #708

Open
JulianKniephoff opened this issue Jun 19, 2024 · 0 comments
Open

Remove rollup-preserve-directives #708

JulianKniephoff opened this issue Jun 19, 2024 · 0 comments

Comments

@JulianKniephoff
Copy link
Member

JulianKniephoff commented Jun 19, 2024

This was added in #709 to work around vitejs/vite#15012. Once that is resolved, we can probably get rid of it.

JulianKniephoff added a commit to JulianKniephoff/opencast-admin-interface that referenced this issue Jun 19, 2024
There are quite a few errors like the following in the output of `npm run build`:

    Error when using sourcemap for reporting an error: Can't resolve original location of error.

They all relate to the `@mui` package(-s). This seems to be related to vitejs/vite#15012.
I don't fully understand it, but apparently Rollup, which is used by Vite internally somehow,
doesn't preserve enough information to generate source maps properly.

This patch adds a plugin to do exactly that. We should probably remove it in the long run,
if the upstream issue(-s) ever get fixed. I created opencast#708 to track that.

/cc opencast#685
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant