Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify some model architectures #147

Open
dfulu opened this issue Feb 27, 2024 · 0 comments
Open

Unify some model architectures #147

dfulu opened this issue Feb 27, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@dfulu
Copy link
Member

dfulu commented Feb 27, 2024 •
edited
Loading

We have some ugly names floating around this repo for model components. We've got ResFCNet2 which is the partner of ResFCNet. We've got ResConv3DNet2 but no ResConv3DNet because ResConv3DNet2 is conceptually the same as ResFCNet2.

We should clean up these names. Either renaming some of these model components or combining them so that both ResFCNet and ResFCNet2 can be derived based on some parameters fed into a single module. And similar for other components
@dfulu dfulu added the enhancement New feature or request label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dfulu