feat: prepare for deprecating client signed urls#448
Draft
rhafer wants to merge 2 commits intoopencloud-eu:mainfrom
Draft
feat: prepare for deprecating client signed urls#448rhafer wants to merge 2 commits intoopencloud-eu:mainfrom
rhafer wants to merge 2 commits intoopencloud-eu:mainfrom
Conversation
rhafer
force-pushed
the
versions-downloadURL
branch
from
0dae00e to
cfdb2cb
Compare
PROPFIND requests to '/dav/meta/.../v' now also include the 'oc:downloadURL' property in the response, if requested. Partial: opencloud-eu/opencloud#1197
rhafer
force-pushed
the
versions-downloadURL
branch
from
cfdb2cb to
c69af3d
Compare
rhafer
changed the title
Author
|
@JammingBen This introduces a new endpoint for the archive that will redirect to a server signed urls for generating an archive. You'd send a request to Does that make sense for web? Or would you prefer some different kind of interface here? |
rhafer
force-pushed
the
versions-downloadURL
branch
from
c69af3d to
08a052b
Compare
|
Yup this should be fine! Does it work unauthenticated on public links and with basic auth on password-protected links as well? And how would I concatenate multiple ids? |
Author
I'd hope so. But I still need to try.
Just like on the old endpoint |
This introduces the new `archiver/v2` endpoint that leverages the recently added url signing mechanism to generated archive download urls. Request to `archiver/v2?id=...&id=...` will get a 303 Response with the `Location` Header pointing to the signed url that can be used for downloading the archive. Partial: opencloud-eu/opencloud#1197
rhafer
force-pushed
the
versions-downloadURL
branch
from
08a052b to
ab26470
Compare
Author
I can confirm that this works for public links (password protected or not) as well. |
Author
|
Argh, I just noticed I introduced a stupid bug that would allow downloading arbitrary files from the creator of a public link. 🤦♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PROPFIND requests to '/dav/meta/.../v' now also include the 'oc:downloadURL' property in the response, if requested.
Also the archive is able now to produce signed urls for downloading an archive.
Partial: opencloud-eu/opencloud#1197