Skip to content

Some event listeners don't get cleaned up #2018

Description

@JammingBen

Initial Checklist

  • I understand this is a bug report and questions should be posted in the Community Discussions
  • I searched issues and couldn’t find anything (or linked relevant results below)

Bug Description

The following event listeners don't get cleaned up an could cause a potential memory leak:

wheel in packages/web-app-preview/src/components/Sources/MediaImage.vue
change in packages/web-pkg/src/services/uppy/uppyService.ts

Reproduction Steps

  • add dev logs to track the registering and unregistering of those listeners
  • open the preview app and close it
  • open the "New"-menu and close it

Expected Outcome

The registered event listeners should be unregistered.

Actual Outcome

They stay registered.

Metadata

Metadata

Assignees

Type

No type

Projects

Status
Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions