moved validaiton before start

Author: senthilsam

pkg/app/app.go

@@ -14,6 +14,7 @@ import (
 	"fmt"
 	"io"
 	"log"
+	"net"
 	"net/http"
 	"os"
 	"sort"
@@ -227,12 +228,17 @@ func (a *App) InitGlobalFlags() {
 
 func (a *App) PreRunE(cmd *cobra.Command, args []string) error {
 	if a.Config.EnablePprof {
-		a.pprof.Start(a.Config.GlobalFlags.PprofAddr)
-		a.Logger.Printf("pprof server started at %s", a.Config.GlobalFlags.PprofAddr)
-		go func() {
-			err := <-a.pprof.ErrChan()
-			a.Logger.Printf("pprof server failed: %v", err)
-		}()
+		_, _, err := net.SplitHostPort(a.Config.GlobalFlags.PprofAddr)
+		if err != nil {
+			fmt.Printf("pprof error %v", err)
+		} else {
+			a.pprof.Start(a.Config.GlobalFlags.PprofAddr)
+			a.Logger.Printf("pprof server started at %s/debug/pprof", a.Config.GlobalFlags.PprofAddr)
+			go func() {
+				err := <-a.pprof.ErrChan()
+				a.Logger.Printf("pprof server failed: %v", err)
+			}()
+		}
 	}
 
 	a.Config.SetGlobalsFromEnv(a.RootCmd)

pkg/app/pprof.go

@@ -1,8 +1,6 @@
 package app
 
 import (
-	"fmt"
-	"net"
 	"net/http"
 	_ "net/http/pprof" //nolint:gosec // Import for pprof, only enabled via CLI flag
 	"time"
@@ -20,12 +18,6 @@ func newPprofServer() *pprofServer {
 
 func (p *pprofServer) Start(address string) {
 	go func() {
-		_, _, err := net.SplitHostPort(address)
-		if err != nil {
-			fmt.Printf("error %v,  using default %q", err, defaultPprofAddr)
-			address = defaultPprofAddr
-		}
-
 		server := &http.Server{
 			Addr:              address,
 			ReadHeaderTimeout: 10 * time.Second,