Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove job that adds needs-triage label #148

Closed
wants to merge 1 commit into from
Closed

Remove job that adds needs-triage label #148

wants to merge 1 commit into from

Conversation

ChristianZaccaria
Copy link
Contributor

Closes #147

Description

Removed the job and updated workflow as we now make use of priorities instead.

Open Question

  • Should we add a different label such as a priority?
  • Or, add no labels. To be added during grooming.

@openshift-ci
Copy link

openshift-ci bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign anishasthana for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ChristianZaccaria
Copy link
Contributor Author

/hold I'll move this workflow to common repo, to be consumed by DW components

@ChristianZaccaria ChristianZaccaria mentioned this pull request Oct 24, 2023
Closed
@ChristianZaccaria ChristianZaccaria mentioned this pull request Nov 2, 2023
Merged
4 tasks
Bobbins228
Bobbins228 requested changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be held off until this is merged too

.github/workflows/use-common-workflow.yaml
- opened
jobs:
call-common-workflow:
uses: project-codeflare/codeflare-common/.github/workflows/common-workflow.yaml@main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this will trigger the common-workflow from this repository.

Have you tried workflow_dispatch?
You can see a working example of triggering one workflow in repository A to repository B

@sutaakar
Copy link
Contributor

Not relevant any more, closing

@sutaakar sutaakar closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bobbins228 Bobbins228 Bobbins228 requested changes

@jbusche jbusche Awaiting requested review from jbusche

@jiripetrlik jiripetrlik Awaiting requested review from jiripetrlik

Assignees

@Bobbins228 Bobbins228

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update auto-add-issues GitHub Action
3 participants
@ChristianZaccaria @sutaakar @Bobbins228