Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that make generate does not result in uncommitted changes #403

Open
jiridanek opened this issue Oct 2, 2024 · 2 comments
Open

Check that make generate does not result in uncommitted changes #403

jiridanek opened this issue Oct 2, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@jiridanek
Copy link
Member 

          /lgtm

Should we consider to run this periodically somehow? 🤔

Originally posted by @jstourac in #392 (comment)
@atheo89
Copy link
Member

atheo89 commented Oct 2, 2024

Let's use a github action for this, here it is a PR that introduce it #404

@jiridanek
Copy link
Member Author

That's not the gha we need, we need something like https://github.com/kubeflow/notebooks/blob/f852c1683e86e9bbdf9502576d51d2d6771b8dab/.github/workflows/ui-bff-build.yml#L25 that @ederign did for Notebooks 2.0

@jiridanek jiridanek added the good first issue Good for newcomers label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jiridanek @atheo89