Skip to content

HOLD: add label to NS #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cooktheryan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

HOLD: add label to NS #285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions kubernetes/namespace/namespace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,5 @@ metadata:
name: llama-serve
annotations:
argocd.argoproj.io/sync-wave: "0"
labels:
modelmesh-enabled: 'false'
Comment on lines +7 to +8
Copy link

@coderabbitai coderabbitai bot Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix: labels are incorrectly nested under annotations; move to metadata.labels

In Kubernetes, metadata.annotations values must be strings, and labels must be a sibling of annotations under metadata. As written, this will fail validation (annotations contains an object-valued key "labels"). Place labels directly under metadata.

Apply this diff to correct the structure:

 metadata:
   name: llama-serve
-  annotations:
-    argocd.argoproj.io/sync-wave: "0"
-    labels:
-      modelmesh-enabled: 'false'
+  labels:
+    modelmesh-enabled: "false"
+  annotations:
+    argocd.argoproj.io/sync-wave: "0"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
labels:
modelmesh-enabled: 'false'
metadata:
name: llama-serve
labels:
modelmesh-enabled: "false"
annotations:
argocd.argoproj.io/sync-wave: "0"
🤖 Prompt for AI Agents 
In kubernetes/namespace/namespace.yaml around lines 7 to 8, the labels block is
mistakenly placed under metadata.annotations (creating an object-valued
annotation) which breaks validation; move the labels map out of annotations and
place it as a sibling under metadata.labels with string values (e.g.,
modelmesh-enabled: "false"), removing the labels key from annotations so
annotations contains only string key:value pairs.