From 3f4151227b18ad78c72bc1cc1ff703157179c6c8 Mon Sep 17 00:00:00 2001
From: Manaswini Das <dasmanaswini10@gmail.com>
Date: Tue, 15 Oct 2024 19:42:41 +0530
Subject: [PATCH] Fix misleading label after creating model registry (#3324)

* Fix misleading label after creating model registry

* Add isScrollable to fix RHOAIENG-13051

* Add test to include ContainerCreating use case
---
 .../RoleBindingPermissionsNameInput.tsx         |  1 +
 .../screens/ModelRegistrySelector.tsx           |  1 +
 .../ModelRegistryTableRowStatus.tsx             |  5 ++++-
 .../ModelRegistryTableRowStatus.spec.tsx        | 17 +++++++++++++++++
 4 files changed, 23 insertions(+), 1 deletion(-)

diff --git a/frontend/src/concepts/roleBinding/RoleBindingPermissionsNameInput.tsx b/frontend/src/concepts/roleBinding/RoleBindingPermissionsNameInput.tsx
index 0bc24d036c..7972ac5539 100644
--- a/frontend/src/concepts/roleBinding/RoleBindingPermissionsNameInput.tsx
+++ b/frontend/src/concepts/roleBinding/RoleBindingPermissionsNameInput.tsx
@@ -57,6 +57,7 @@ const RoleBindingPermissionsNameInput: React.FC<RoleBindingPermissionsNameInputP
   }
   return (
     <TypeaheadSelect
+      isScrollable
       selectOptions={selectOptions}
       selected={value}
       isCreatable
diff --git a/frontend/src/pages/modelRegistry/screens/ModelRegistrySelector.tsx b/frontend/src/pages/modelRegistry/screens/ModelRegistrySelector.tsx
index 146c483b17..5f54484c7c 100644
--- a/frontend/src/pages/modelRegistry/screens/ModelRegistrySelector.tsx
+++ b/frontend/src/pages/modelRegistry/screens/ModelRegistrySelector.tsx
@@ -121,6 +121,7 @@ const ModelRegistrySelector: React.FC<ModelRegistrySelectorProps> = ({
 
   const selector = (
     <Select
+      isScrollable
       toggle={(toggleRef) => (
         <MenuToggle
           ref={toggleRef}
diff --git a/frontend/src/pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx b/frontend/src/pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx
index 734cef714c..463370d72f 100644
--- a/frontend/src/pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx
+++ b/frontend/src/pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx
@@ -67,7 +67,10 @@ export const ModelRegistryTableRowStatus: React.FC<ModelRegistryTableRowStatusPr
         : [];
 
     // Unavailable
-    if (availableCondition?.status === ConditionStatus.False) {
+    if (
+      availableCondition?.status === ConditionStatus.False &&
+      !popoverMessages.some((message) => message.includes('ContainerCreating'))
+    ) {
       statusLabel = ModelRegistryStatusLabel.Unavailable;
       icon = <ExclamationCircleIcon />;
       color = 'red';
diff --git a/frontend/src/pages/modelRegistrySettings/__tests__/ModelRegistryTableRowStatus.spec.tsx b/frontend/src/pages/modelRegistrySettings/__tests__/ModelRegistryTableRowStatus.spec.tsx
index 5480436aae..9146c5bb20 100644
--- a/frontend/src/pages/modelRegistrySettings/__tests__/ModelRegistryTableRowStatus.spec.tsx
+++ b/frontend/src/pages/modelRegistrySettings/__tests__/ModelRegistryTableRowStatus.spec.tsx
@@ -221,6 +221,23 @@ describe('ModelRegistryTableRowStatus', () => {
     expect(degradingText).toBeInTheDocument();
   });
 
+  it('renders "Progressing" status when popover message contains "ContainerCreating"', async () => {
+    render(
+      <ModelRegistryTableRowStatus
+        conditions={[
+          {
+            status: 'False',
+            type: 'Unavailable',
+            message:
+              'Deployment is unavailable: pod test has unready containers [grpc-container: {waiting: {reason: ContainerCreating, message: }}',
+          },
+        ]}
+      />,
+    );
+
+    expect(screen.getByText('Progressing')).toBeVisible();
+  });
+
   it('renders "Progressing" status when conditions are empty', () => {
     render(<ModelRegistryTableRowStatus conditions={[]} />);
     expect(screen.getByText('Progressing')).toBeVisible();