From 5581898ed146701931583a0c7b15378a173ab767 Mon Sep 17 00:00:00 2001 From: Ashique Ansari Date: Mon, 10 Jul 2023 23:32:00 +0530 Subject: [PATCH] handling suggestions --- frontend/src/concepts/pipelines/const.ts | 2 ++ .../content/tables/pipeline/PipelinesTableExpandedRow.tsx | 2 +- .../pipelines/content/tables/pipeline/PipelinesTableRow.tsx | 2 +- frontend/src/const.ts | 2 -- .../pages/projects/screens/detail/pipelines/PipelinesList.tsx | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/frontend/src/concepts/pipelines/const.ts b/frontend/src/concepts/pipelines/const.ts index 706b4a2dfa..353146946d 100644 --- a/frontend/src/concepts/pipelines/const.ts +++ b/frontend/src/concepts/pipelines/const.ts @@ -1,2 +1,4 @@ export const PIPELINE_ROUTE_NAME = 'ds-pipeline-pipelines-definition'; export const PIPELINE_DEFINITION_NAME = 'pipelines-definition'; +export const TABLE_CONTENT_LIMIT = 5; +export const LIMIT_MAX_ITEM_COUNT = TABLE_CONTENT_LIMIT + 1; diff --git a/frontend/src/concepts/pipelines/content/tables/pipeline/PipelinesTableExpandedRow.tsx b/frontend/src/concepts/pipelines/content/tables/pipeline/PipelinesTableExpandedRow.tsx index 6f1eeaef8e..7b93fdeb78 100644 --- a/frontend/src/concepts/pipelines/content/tables/pipeline/PipelinesTableExpandedRow.tsx +++ b/frontend/src/concepts/pipelines/content/tables/pipeline/PipelinesTableExpandedRow.tsx @@ -13,7 +13,7 @@ import { PipelineKF, PipelineRunKF } from '~/concepts/pipelines/kfTypes'; import IndentSection from '~/pages/projects/components/IndentSection'; import { FetchState } from '~/utilities/useFetchState'; import { usePipelinesAPI } from '~/concepts/pipelines/context'; -import { TABLE_CONTENT_LIMIT } from '~/const'; +import { TABLE_CONTENT_LIMIT } from '~/concepts/pipelines/const'; import { RenderContentList, combineRunsByColumn } from './expandedRowRenderUtils'; type PipelinesTableExpandedRowProps = { diff --git a/frontend/src/concepts/pipelines/content/tables/pipeline/PipelinesTableRow.tsx b/frontend/src/concepts/pipelines/content/tables/pipeline/PipelinesTableRow.tsx index 84445ace67..1ad301a8b3 100644 --- a/frontend/src/concepts/pipelines/content/tables/pipeline/PipelinesTableRow.tsx +++ b/frontend/src/concepts/pipelines/content/tables/pipeline/PipelinesTableRow.tsx @@ -16,7 +16,7 @@ import { RunNameForPipeline, RunStatus, } from '~/concepts/pipelines/content/tables/renderUtils'; -import { LIMIT_MAX_ITEM_COUNT } from '~/const'; +import { LIMIT_MAX_ITEM_COUNT } from '~/concepts/pipelines/const'; type PipelinesTableRowProps = { pipeline: PipelineKF; diff --git a/frontend/src/const.ts b/frontend/src/const.ts index 83ee7f4174..73be687c75 100644 --- a/frontend/src/const.ts +++ b/frontend/src/const.ts @@ -4,5 +4,3 @@ export const LABEL_SELECTOR_DASHBOARD_RESOURCE = `${KnownLabels.DASHBOARD_RESOUR export const LABEL_SELECTOR_MODEL_SERVING_PROJECT = `${KnownLabels.MODEL_SERVING_PROJECT}=true`; export const LABEL_SELECTOR_DATA_CONNECTION_AWS = `${KnownLabels.DATA_CONNECTION_AWS}=true`; export const LABEL_SELECTOR_PROJECT_SHARING = `${KnownLabels.PROJECT_SHARING}=true`; -export const TABLE_CONTENT_LIMIT = 5; -export const LIMIT_MAX_ITEM_COUNT = 6; diff --git a/frontend/src/pages/projects/screens/detail/pipelines/PipelinesList.tsx b/frontend/src/pages/projects/screens/detail/pipelines/PipelinesList.tsx index 2c9de207d5..f038c0d882 100644 --- a/frontend/src/pages/projects/screens/detail/pipelines/PipelinesList.tsx +++ b/frontend/src/pages/projects/screens/detail/pipelines/PipelinesList.tsx @@ -7,7 +7,7 @@ import usePipelines from '~/concepts/pipelines/apiHooks/usePipelines'; import IndentSection from '~/pages/projects/components/IndentSection'; import { usePipelinesAPI } from '~/concepts/pipelines/context'; import EmptyStateErrorMessage from '~/components/EmptyStateErrorMessage'; -import { TABLE_CONTENT_LIMIT, LIMIT_MAX_ITEM_COUNT } from '~/const'; +import { TABLE_CONTENT_LIMIT, LIMIT_MAX_ITEM_COUNT } from '~/concepts/pipelines/const'; const PipelinesList: React.FC = () => { const { namespace } = usePipelinesAPI();