From b817bcc8a2848a952bdf217038d1a4e1fe81fb5c Mon Sep 17 00:00:00 2001
From: Dipanshu Gupta <dipanshug421@gmail.com>
Date: Wed, 8 May 2024 19:25:44 +0530
Subject: [PATCH] Model version details test Refactoring model registry folder
 structure

---
 frontend/src/__mocks__/mockModelArtifact.ts   |  13 +++
 .../src/__mocks__/mockModelArtifactList.ts    |  10 ++
 frontend/src/__mocks__/mockModelVersion.ts    |  54 ++++++++-
 .../src/__mocks__/mockModelVersionList.ts     |   7 +-
 .../e2e/modelRegistry/ModelRegistry.cy.ts     |   3 +-
 .../modelRegistry/ModelVersionDetails.cy.ts   | 104 ++++++++++++++++++
 .../modelRegistry/modelVersionDetails.ts      |  48 ++++++++
 .../cypress/cypress/support/commands/odh.ts   |  30 ++++-
 .../EditableLabelsDescriptionListGroup.tsx    |   4 +-
 .../EditableTextDescriptionListGroup.tsx      |   3 +
 .../modelRegistry/ModelRegistryRoutes.tsx     |  14 +--
 .../modelRegistry/screens/ModelRegistry.tsx   |   2 +-
 .../ModelVersionDetails.tsx                   |   8 +-
 .../ModelVersionDetailsView.tsx               |  21 +++-
 .../ModelVersionSelector.tsx                  |   3 +-
 .../GlobalModelVersionsTabs.tsx               |   8 +-
 .../{ => ModelVersions}/ModelDetailsView.tsx  |   6 +-
 .../ModelVersionListView.tsx                  |  10 +-
 .../{ => ModelVersions}/ModelVersions.tsx     |   4 +-
 .../ModelVersionsHeaderActions.tsx            |   0
 .../ModelVersionsTable.tsx                    |   0
 .../ModelVersionsTableColumns.ts              |   0
 .../ModelVersionsTableRow.tsx                 |   6 +-
 .../screens/{ => ModelVersions}/const.ts      |   2 +-
 .../RegisteredModelListView.tsx               |   0
 .../RegisteredModelOwner.tsx                  |   0
 .../RegisteredModelTable.tsx                  |   0
 .../RegisteredModelTableRow.tsx               |  10 +-
 .../RegisteredModelsTableColumns.ts           |   0
 .../RegisteredModelsTableToolbar.tsx          |   0
 .../screens/{ => components}/ModelLabels.tsx  |   2 +-
 .../{ => components}/ModelTimestamp.tsx       |   0
 .../src/pages/modelRegistry/screens/utils.ts  |   6 +-
 33 files changed, 324 insertions(+), 54 deletions(-)
 create mode 100644 frontend/src/__mocks__/mockModelArtifact.ts
 create mode 100644 frontend/src/__mocks__/mockModelArtifactList.ts
 create mode 100644 frontend/src/__tests__/cypress/cypress/e2e/modelRegistry/ModelVersionDetails.cy.ts
 create mode 100644 frontend/src/__tests__/cypress/cypress/pages/modelRegistry/modelVersionDetails.ts
 rename frontend/src/pages/modelRegistry/screens/{ => ModelVersions}/GlobalModelVersionsTabs.tsx (90%)
 rename frontend/src/pages/modelRegistry/screens/{ => ModelVersions}/ModelDetailsView.tsx (93%)
 rename frontend/src/pages/modelRegistry/screens/{ => ModelVersions}/ModelVersionListView.tsx (92%)
 rename frontend/src/pages/modelRegistry/screens/{ => ModelVersions}/ModelVersions.tsx (96%)
 rename frontend/src/pages/modelRegistry/screens/{ => ModelVersions}/ModelVersionsHeaderActions.tsx (100%)
 rename frontend/src/pages/modelRegistry/screens/{ => ModelVersions}/ModelVersionsTable.tsx (100%)
 rename frontend/src/pages/modelRegistry/screens/{ => ModelVersions}/ModelVersionsTableColumns.ts (100%)
 rename frontend/src/pages/modelRegistry/screens/{ => ModelVersions}/ModelVersionsTableRow.tsx (89%)
 rename frontend/src/pages/modelRegistry/screens/{ => ModelVersions}/const.ts (81%)
 rename frontend/src/pages/modelRegistry/screens/{ => RegisteredModels}/RegisteredModelListView.tsx (100%)
 rename frontend/src/pages/modelRegistry/screens/{ => RegisteredModels}/RegisteredModelOwner.tsx (100%)
 rename frontend/src/pages/modelRegistry/screens/{ => RegisteredModels}/RegisteredModelTable.tsx (100%)
 rename frontend/src/pages/modelRegistry/screens/{ => RegisteredModels}/RegisteredModelTableRow.tsx (86%)
 rename frontend/src/pages/modelRegistry/screens/{ => RegisteredModels}/RegisteredModelsTableColumns.ts (100%)
 rename frontend/src/pages/modelRegistry/screens/{ => RegisteredModels}/RegisteredModelsTableToolbar.tsx (100%)
 rename frontend/src/pages/modelRegistry/screens/{ => components}/ModelLabels.tsx (98%)
 rename frontend/src/pages/modelRegistry/screens/{ => components}/ModelTimestamp.tsx (100%)

diff --git a/frontend/src/__mocks__/mockModelArtifact.ts b/frontend/src/__mocks__/mockModelArtifact.ts
new file mode 100644
index 0000000000..3bf055eb33
--- /dev/null
+++ b/frontend/src/__mocks__/mockModelArtifact.ts
@@ -0,0 +1,13 @@
+import { ModelArtifact } from '~/concepts/modelRegistry/types';
+
+export const mockModelArtifact = (): ModelArtifact => ({
+  createTimeSinceEpoch: '1712234877179',
+  id: '1',
+  lastUpdateTimeSinceEpoch: '1712234877179',
+  name: 'fraud detection model version 1',
+  description: 'Description of model version',
+  artifactType: 'model-artifact',
+  customProperties: {},
+  storagePath: 'test path',
+  uri: 'https://huggingface.io/mnist.onnx',
+});
diff --git a/frontend/src/__mocks__/mockModelArtifactList.ts b/frontend/src/__mocks__/mockModelArtifactList.ts
new file mode 100644
index 0000000000..6e4e3edcef
--- /dev/null
+++ b/frontend/src/__mocks__/mockModelArtifactList.ts
@@ -0,0 +1,10 @@
+/* eslint-disable camelcase */
+import { ModelArtifactList } from '~/concepts/modelRegistry/types';
+import { mockModelArtifact } from './mockModelArtifact';
+
+export const mockModelArtifactList = (): ModelArtifactList => ({
+  items: [mockModelArtifact()],
+  nextPageToken: '',
+  pageSize: 0,
+  size: 1,
+});
diff --git a/frontend/src/__mocks__/mockModelVersion.ts b/frontend/src/__mocks__/mockModelVersion.ts
index afe27ff872..ab5c1494a5 100644
--- a/frontend/src/__mocks__/mockModelVersion.ts
+++ b/frontend/src/__mocks__/mockModelVersion.ts
@@ -1,20 +1,68 @@
+/* eslint-disable camelcase */
 import { ModelVersion, ModelVersionState } from '~/concepts/modelRegistry/types';
 
 type MockModelVersionType = {
+  name?: string;
   author?: string;
   registeredModelId?: string;
+  id?: string;
 };
 
 export const mockModelVersion = ({
+  name = 'Version 1',
   author = 'Test author',
   registeredModelId = '1',
+  id = '1',
 }: MockModelVersionType): ModelVersion => ({
   author,
   createTimeSinceEpoch: '1712234877179',
-  customProperties: {},
-  id: '26',
+  customProperties: {
+    'Testing label': {
+      metadataType: 'MetadataStringValue',
+      string_value: '',
+    },
+    Financial: {
+      metadataType: 'MetadataStringValue',
+      string_value: 'non-empty',
+    },
+    'Financial data': {
+      metadataType: 'MetadataStringValue',
+      string_value: '',
+    },
+    'Fraud detection': {
+      metadataType: 'MetadataStringValue',
+      string_value: '',
+    },
+    'Long label data to be truncated abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc':
+      {
+        metadataType: 'MetadataStringValue',
+        string_value: '',
+      },
+    'Machine learning': {
+      metadataType: 'MetadataStringValue',
+      string_value: '',
+    },
+    'Next data to be overflow': {
+      metadataType: 'MetadataStringValue',
+      string_value: '',
+    },
+    'Label x': {
+      metadataType: 'MetadataStringValue',
+      string_value: '',
+    },
+    'Label y': {
+      metadataType: 'MetadataStringValue',
+      string_value: '',
+    },
+    'Label z': {
+      metadataType: 'MetadataStringValue',
+      string_value: '',
+    },
+  },
+  id,
   lastUpdateTimeSinceEpoch: '1712234877179',
-  name: 'fraud detection model version 1',
+  name,
   state: ModelVersionState.ARCHIVED,
   registeredModelId,
+  description: 'Description of model version',
 });
diff --git a/frontend/src/__mocks__/mockModelVersionList.ts b/frontend/src/__mocks__/mockModelVersionList.ts
index c9e845c93f..d19d91e7af 100644
--- a/frontend/src/__mocks__/mockModelVersionList.ts
+++ b/frontend/src/__mocks__/mockModelVersionList.ts
@@ -2,8 +2,11 @@ import { ModelVersionList } from '~/concepts/modelRegistry/types';
 import { mockModelVersion } from './mockModelVersion';
 
 export const mockModelVersionList = (): ModelVersionList => ({
-  items: [mockModelVersion({ author: 'Author 1', registeredModelId: '1' })],
+  items: [
+    mockModelVersion({ author: 'Author 1', registeredModelId: '1' }),
+    mockModelVersion({ author: 'Author 2', registeredModelId: '1', id: '2', name: 'Version 2' }),
+  ],
   nextPageToken: '',
   pageSize: 0,
-  size: 1,
+  size: 2,
 });
diff --git a/frontend/src/__tests__/cypress/cypress/e2e/modelRegistry/ModelRegistry.cy.ts b/frontend/src/__tests__/cypress/cypress/e2e/modelRegistry/ModelRegistry.cy.ts
index f09391c755..870e72c9eb 100644
--- a/frontend/src/__tests__/cypress/cypress/e2e/modelRegistry/ModelRegistry.cy.ts
+++ b/frontend/src/__tests__/cypress/cypress/e2e/modelRegistry/ModelRegistry.cy.ts
@@ -68,6 +68,7 @@ describe('Model Registry', () => {
 
     modelRegistry.tabEnabled();
   });
+
   it('No registered models in the selected Model Registry', () => {
     initIntercepts({
       disableModelRegistryFeature: false,
@@ -80,7 +81,7 @@ describe('Model Registry', () => {
     modelRegistry.shouldregisteredModelsEmpty();
   });
 
-  it('Model registry table', () => {
+  it('Registered model table', () => {
     initIntercepts({
       disableModelRegistryFeature: false,
     });
diff --git a/frontend/src/__tests__/cypress/cypress/e2e/modelRegistry/ModelVersionDetails.cy.ts b/frontend/src/__tests__/cypress/cypress/e2e/modelRegistry/ModelVersionDetails.cy.ts
new file mode 100644
index 0000000000..6b9c69f670
--- /dev/null
+++ b/frontend/src/__tests__/cypress/cypress/e2e/modelRegistry/ModelVersionDetails.cy.ts
@@ -0,0 +1,104 @@
+import {
+  mockDashboardConfig,
+  mockK8sResourceList,
+  mockRouteK8sResourceModelRegistry,
+} from '~/__mocks__';
+import { mockComponents } from '~/__mocks__/mockComponents';
+import { mockModelRegistry } from '~/__mocks__/mockModelRegistry';
+import { ModelRegistryModel, RouteModel } from '~/__tests__/cypress/cypress/utils/models';
+import { MODEL_REGISTRY_API_VERSION } from '~/concepts/modelRegistry/const';
+import { modelVersionDetails } from '~/__tests__/cypress/cypress/pages/modelRegistry/modelVersionDetails';
+import { mockRegisteredModel } from '~/__mocks__/mockRegisteredModel';
+import { mockModelVersion } from '~/__mocks__/mockModelVersion';
+import { mockModelVersionList } from '~/__mocks__/mockModelVersionList';
+import { mockModelArtifactList } from '~/__mocks__/mockModelArtifactList';
+import { verifyRelativeURL } from '~/__tests__/cypress/cypress/utils/url';
+
+const initIntercepts = () => {
+  cy.interceptOdh(
+    'GET /api/config',
+    mockDashboardConfig({
+      disableModelRegistry: false,
+    }),
+  );
+  cy.interceptOdh('GET /api/components', { query: { installed: 'true' } }, mockComponents());
+
+  cy.interceptK8sList(ModelRegistryModel, mockK8sResourceList([mockModelRegistry({})]));
+
+  cy.interceptK8s(ModelRegistryModel, mockModelRegistry({}));
+
+  cy.interceptK8s(
+    RouteModel,
+    mockRouteK8sResourceModelRegistry({
+      name: 'modelregistry-sample-http',
+      namespace: 'odh-model-registries',
+    }),
+  );
+
+  cy.interceptOdh(
+    `GET /api/service/modelregistry/modelregistry-sample/api/model_registry/${MODEL_REGISTRY_API_VERSION}/registered_models/1`,
+    mockRegisteredModel({}),
+  );
+
+  cy.interceptOdh(
+    `GET /api/service/modelregistry/modelregistry-sample/api/model_registry/${MODEL_REGISTRY_API_VERSION}/registered_models/1/versions`,
+    mockModelVersionList(),
+  );
+
+  cy.interceptOdh(
+    `GET /api/service/modelregistry/modelregistry-sample/api/model_registry/${MODEL_REGISTRY_API_VERSION}/model_versions/:id`,
+    { path: { id: '1' } },
+    mockModelVersion({}),
+  );
+
+  cy.interceptOdh(
+    `GET /api/service/modelregistry/modelregistry-sample/api/model_registry/${MODEL_REGISTRY_API_VERSION}/model_versions/:id`,
+    { path: { id: '2' } },
+    mockModelVersion({ id: '2', name: 'Version 2' }),
+  );
+
+  cy.interceptOdh(
+    `GET /api/service/modelregistry/modelregistry-sample/api/model_registry/${MODEL_REGISTRY_API_VERSION}/model_versions/1/artifacts`,
+    mockModelArtifactList(),
+  );
+};
+
+describe('Model version details', () => {
+  beforeEach(() => {
+    initIntercepts();
+    modelVersionDetails.visit();
+  });
+
+  it('Model version details page header', () => {
+    verifyRelativeURL('/modelRegistry/modelregistry-sample/registeredModels/1/versions/1/details');
+    cy.findByTestId('app-page-title').should('have.text', 'Version 1');
+    cy.findByTestId('breadcrumb-version-name').should('have.text', 'Version 1');
+  });
+
+  it('Model version details tab', () => {
+    modelVersionDetails.findVersionId().contains('1');
+    modelVersionDetails.findDescription().should('have.text', 'Description of model version');
+    modelVersionDetails.findMoreLabelsButton().contains('6 more');
+    modelVersionDetails.findMoreLabelsButton().click();
+    modelVersionDetails.shouldContainsModalLabels([
+      'Testing label',
+      'Financial',
+      'Financial data',
+      'Fraud detection',
+      'Machine learning',
+      'Next data to be overflow',
+      'Label x',
+      'Label y',
+      'Label z',
+    ]);
+    modelVersionDetails.findStorageLocation().contains('https://huggingface.io/mnist.onnx');
+  });
+
+  it('Switching model versions', () => {
+    modelVersionDetails.findVersionId().contains('1');
+    modelVersionDetails.findModelVersionDropdownButton().click();
+    modelVersionDetails.findModelVersionDropdownSearch().fill('Version 2');
+    modelVersionDetails.findModelVersionDropdownItem('Version 2').click();
+    modelVersionDetails.findVersionId().contains('2');
+  });
+});
diff --git a/frontend/src/__tests__/cypress/cypress/pages/modelRegistry/modelVersionDetails.ts b/frontend/src/__tests__/cypress/cypress/pages/modelRegistry/modelVersionDetails.ts
new file mode 100644
index 0000000000..d28bf590f6
--- /dev/null
+++ b/frontend/src/__tests__/cypress/cypress/pages/modelRegistry/modelVersionDetails.ts
@@ -0,0 +1,48 @@
+import { modelVersionUrl } from '~/pages/modelRegistry/screens/routeUtils';
+
+class ModelVersionDetails {
+  visit() {
+    cy.visit(modelVersionUrl('1', '1', 'modelregistry-sample'));
+    this.wait();
+  }
+
+  private wait() {
+    cy.findByTestId('app-page-title').should('exist');
+    cy.testA11y();
+  }
+
+  findVersionId() {
+    return cy.findByTestId('model-version-id');
+  }
+
+  findDescription() {
+    return cy.findByTestId('model-version-description');
+  }
+
+  findMoreLabelsButton() {
+    return cy.findByTestId('label-group').find('button');
+  }
+
+  findStorageLocation() {
+    return cy.findByTestId('storage-location');
+  }
+
+  shouldContainsModalLabels(labels: string[]) {
+    cy.findByTestId('label-group').within(() => labels.map((label) => cy.contains(label)));
+    return this;
+  }
+
+  findModelVersionDropdownButton() {
+    return cy.findByTestId('model-version-toggle-button');
+  }
+
+  findModelVersionDropdownSearch() {
+    return cy.findByTestId('search-input');
+  }
+
+  findModelVersionDropdownItem(name: string) {
+    return cy.findByTestId('model-version-selector-list').find('li').contains(name);
+  }
+}
+
+export const modelVersionDetails = new ModelVersionDetails();
diff --git a/frontend/src/__tests__/cypress/cypress/support/commands/odh.ts b/frontend/src/__tests__/cypress/cypress/support/commands/odh.ts
index 8b3e30b8bc..e3030384a8 100644
--- a/frontend/src/__tests__/cypress/cypress/support/commands/odh.ts
+++ b/frontend/src/__tests__/cypress/cypress/support/commands/odh.ts
@@ -1,7 +1,13 @@
 import { K8sResourceListResult, K8sStatus } from '@openshift/dynamic-plugin-sdk-utils';
 import type { GenericStaticResponse, RouteHandlerController } from 'cypress/types/net-stubbing';
 import { BaseMetricCreationResponse, BaseMetricListResponse } from '~/api';
-import { ModelVersionList, RegisteredModelList } from '~/concepts/modelRegistry/types';
+import {
+  ModelArtifactList,
+  ModelVersion,
+  ModelVersionList,
+  RegisteredModel,
+  RegisteredModelList,
+} from '~/concepts/modelRegistry/types';
 import type {
   DashboardConfigKind,
   DataScienceClusterInitializationKindStatus,
@@ -316,9 +322,19 @@ declare global {
       ): Cypress.Chainable<null>;
 
       interceptOdh(
-        type: 'DELETE /api/service/pipelines/:projectId/dspa/apis/v2beta1/recurringruns/:pipeline_id',
-        options: { path: { projectId: string; pipeline_id: string } },
-        response: OdhResponse<K8sStatus>,
+        type: `GET /api/service/modelregistry/modelregistry-sample/api/model_registry/v1alpha3/registered_models/1`,
+        response: OdhResponse<RegisteredModel | undefined>,
+      ): Cypress.Chainable<null>;
+
+      interceptOdh(
+        type: `GET /api/service/modelregistry/modelregistry-sample/api/model_registry/v1alpha3/model_versions/:id`,
+        options: { path: { id: string } },
+        response: OdhResponse<ModelVersion | undefined>,
+      ): Cypress.Chainable<null>;
+
+      interceptOdh(
+        type: `GET /api/service/modelregistry/modelregistry-sample/api/model_registry/v1alpha3/model_versions/1/artifacts`,
+        response: OdhResponse<ModelArtifactList | undefined>,
       ): Cypress.Chainable<null>;
 
       interceptOdh(
@@ -326,6 +342,12 @@ declare global {
         response: OdhResponse<ModelVersionList | undefined>,
       ): Cypress.Chainable<null>;
 
+      interceptOdh(
+        type: 'DELETE /api/service/pipelines/:projectId/dspa/apis/v2beta1/recurringruns/:pipeline_id',
+        options: { path: { projectId: string; pipeline_id: string } },
+        response: OdhResponse<K8sStatus>,
+      ): Cypress.Chainable<null>;
+
       interceptOdh(
         type: 'GET /api/rolebindings/opendatahub/openshift-ai-notebooks-image-pullers',
         response: OdhResponse<K8sResourceListResult<RoleBindingKind>>,
diff --git a/frontend/src/components/EditableLabelsDescriptionListGroup.tsx b/frontend/src/components/EditableLabelsDescriptionListGroup.tsx
index 04fec7a257..df87de0b40 100644
--- a/frontend/src/components/EditableLabelsDescriptionListGroup.tsx
+++ b/frontend/src/components/EditableLabelsDescriptionListGroup.tsx
@@ -132,9 +132,9 @@ const EditableLabelsDescriptionListGroup: React.FC<EditableTextDescriptionListGr
           setIsEditing(false);
         }}
       >
-        <LabelGroup>
+        <LabelGroup data-testid="label-group">
           {labels.map((label) => (
-            <Label key={label} color="blue" data-testid="label">
+            <Label textMaxWidth="40ch" key={label} color="blue" data-testid="label">
               {label}
             </Label>
           ))}
diff --git a/frontend/src/components/EditableTextDescriptionListGroup.tsx b/frontend/src/components/EditableTextDescriptionListGroup.tsx
index 19589e0d82..b421697f1e 100644
--- a/frontend/src/components/EditableTextDescriptionListGroup.tsx
+++ b/frontend/src/components/EditableTextDescriptionListGroup.tsx
@@ -10,6 +10,7 @@ type EditableTextDescriptionListGroupProps = Pick<
 > & {
   value: string;
   saveEditedValue: (value: string) => Promise<void>;
+  testid?: string;
 };
 
 const EditableTextDescriptionListGroup: React.FC<EditableTextDescriptionListGroupProps> = ({
@@ -17,6 +18,7 @@ const EditableTextDescriptionListGroup: React.FC<EditableTextDescriptionListGrou
   contentWhenEmpty,
   value,
   saveEditedValue,
+  testid,
 }) => {
   const [isEditing, setIsEditing] = React.useState(false);
   const [unsavedValue, setUnsavedValue] = React.useState(value);
@@ -58,6 +60,7 @@ const EditableTextDescriptionListGroup: React.FC<EditableTextDescriptionListGrou
       }}
     >
       <ExpandableSection
+        data-testid={testid}
         variant="truncate"
         truncateMaxLines={12}
         toggleText={isTextExpanded ? 'Show less' : 'Show more'}
diff --git a/frontend/src/pages/modelRegistry/ModelRegistryRoutes.tsx b/frontend/src/pages/modelRegistry/ModelRegistryRoutes.tsx
index 1efe05a190..e080c71ceb 100644
--- a/frontend/src/pages/modelRegistry/ModelRegistryRoutes.tsx
+++ b/frontend/src/pages/modelRegistry/ModelRegistryRoutes.tsx
@@ -3,8 +3,8 @@ import { Navigate, Route, Routes } from 'react-router-dom';
 import { ModelRegistrySelectorContextProvider } from '~/concepts/modelRegistry/context/ModelRegistrySelectorContext';
 import ModelRegistryCoreLoader from './ModelRegistryCoreLoader';
 import ModelRegistry from './screens/ModelRegistry';
-import { ModelVersionsTabs } from './screens/const';
-import ModelVersions from './screens/ModelVersions';
+import { ModelVersionsTab } from './screens/ModelVersions/const';
+import ModelVersions from './screens/ModelVersions/ModelVersions';
 import ModelVersionsDetails from './screens/ModelVersionDetails/ModelVersionDetails';
 import { ModelVersionDetailsTab } from './screens/ModelVersionDetails/const';
 
@@ -21,14 +21,14 @@ const ModelRegistryRoutes: React.FC = () => (
       >
         <Route index element={<ModelRegistry />} />
         <Route path="registeredModels/:registeredModelId">
-          <Route index element={<Navigate to={ModelVersionsTabs.VERSIONS} />} />
+          <Route index element={<Navigate to={ModelVersionsTab.VERSIONS} />} />
           <Route
-            path={ModelVersionsTabs.VERSIONS}
-            element={<ModelVersions tab={ModelVersionsTabs.VERSIONS} empty={false} />}
+            path={ModelVersionsTab.VERSIONS}
+            element={<ModelVersions tab={ModelVersionsTab.VERSIONS} empty={false} />}
           />
           <Route
-            path={ModelVersionsTabs.DETAILS}
-            element={<ModelVersions tab={ModelVersionsTabs.DETAILS} empty={false} />}
+            path={ModelVersionsTab.DETAILS}
+            element={<ModelVersions tab={ModelVersionsTab.DETAILS} empty={false} />}
           />
           <Route path="versions/:modelVersionId">
             <Route index element={<Navigate to={ModelVersionDetailsTab.DETAILS} />} />
diff --git a/frontend/src/pages/modelRegistry/screens/ModelRegistry.tsx b/frontend/src/pages/modelRegistry/screens/ModelRegistry.tsx
index f62695e1c9..605a59149c 100644
--- a/frontend/src/pages/modelRegistry/screens/ModelRegistry.tsx
+++ b/frontend/src/pages/modelRegistry/screens/ModelRegistry.tsx
@@ -4,7 +4,7 @@ import useRegisteredModels from '~/concepts/modelRegistry/apiHooks/useRegistered
 import { ModelRegistrySelectorContext } from '~/concepts/modelRegistry/context/ModelRegistrySelectorContext';
 import TitleWithIcon from '~/concepts/design/TitleWithIcon';
 import { ProjectObjectType } from '~/concepts/design/utils';
-import RegisteredModelListView from './RegisteredModelListView';
+import RegisteredModelListView from './RegisteredModels/RegisteredModelListView';
 import EmptyModelRegistryState from './EmptyModelRegistryState';
 import ModelRegistrySelectorNavigator from './ModelRegistrySelectorNavigator';
 
diff --git a/frontend/src/pages/modelRegistry/screens/ModelVersionDetails/ModelVersionDetails.tsx b/frontend/src/pages/modelRegistry/screens/ModelVersionDetails/ModelVersionDetails.tsx
index 009a41139a..7c7cffe350 100644
--- a/frontend/src/pages/modelRegistry/screens/ModelVersionDetails/ModelVersionDetails.tsx
+++ b/frontend/src/pages/modelRegistry/screens/ModelVersionDetails/ModelVersionDetails.tsx
@@ -47,7 +47,13 @@ const ModelVersionsDetails: React.FC<ModelVersionsDetailProps> = ({ tab, ...page
               </Link>
             )}
           />
-          <BreadcrumbItem isActive>{mv?.name}</BreadcrumbItem>
+          <BreadcrumbItem
+            aria-label="Breadcrumb version name"
+            data-testid="breadcrumb-version-name"
+            isActive
+          >
+            {mv?.name}
+          </BreadcrumbItem>
         </Breadcrumb>
       }
       title={mv?.name}
diff --git a/frontend/src/pages/modelRegistry/screens/ModelVersionDetails/ModelVersionDetailsView.tsx b/frontend/src/pages/modelRegistry/screens/ModelVersionDetails/ModelVersionDetailsView.tsx
index 565bbed99e..92757c6a53 100644
--- a/frontend/src/pages/modelRegistry/screens/ModelVersionDetails/ModelVersionDetailsView.tsx
+++ b/frontend/src/pages/modelRegistry/screens/ModelVersionDetails/ModelVersionDetailsView.tsx
@@ -6,7 +6,7 @@ import DashboardDescriptionListGroup from '~/components/DashboardDescriptionList
 import EditableTextDescriptionListGroup from '~/components/EditableTextDescriptionListGroup';
 import EditableLabelsDescriptionListGroup from '~/components/EditableLabelsDescriptionListGroup';
 import { getLabels } from '~/pages/modelRegistry/screens/utils';
-import ModelTimestamp from '~/pages/modelRegistry/screens/ModelTimestamp';
+import ModelTimestamp from '~/pages/modelRegistry/screens/components/ModelTimestamp';
 import useModelArtifactsByVersionId from '~/concepts/modelRegistry/apiHooks/useModelArtifactsByVersionId';
 
 type ModelVersionDetailsViewProps = {
@@ -25,6 +25,7 @@ const ModelVersionDetailsView: React.FC<ModelVersionDetailsViewProps> = ({ model
       <FlexItem flex={{ default: 'flex_1' }}>
         <DescriptionList isFillColumns>
           <EditableTextDescriptionListGroup
+            testid="model-version-description"
             title="Description"
             contentWhenEmpty="No description"
             value={mv.description || ''}
@@ -71,22 +72,32 @@ const ModelVersionDetailsView: React.FC<ModelVersionDetailsViewProps> = ({ model
             isEmpty={!mv.id}
             contentWhenEmpty="No model ID"
           >
-            <ClipboardCopy hoverTip="Copy" clickTip="Copied" variant="inline-compact">
+            <ClipboardCopy
+              data-testid="model-version-id"
+              hoverTip="Copy"
+              clickTip="Copied"
+              variant="inline-compact"
+            >
               {mv.id}
             </ClipboardCopy>
           </DashboardDescriptionListGroup>
           <DashboardDescriptionListGroup
             title="Storage location"
-            isEmpty={modelArtifact.size === 0}
+            isEmpty={modelArtifact.size === 0 || !modelArtifact.items[0].uri}
             contentWhenEmpty="No storage location"
           >
-            <ClipboardCopy hoverTip="Copy" clickTip="Copied" variant="inline-compact">
+            <ClipboardCopy
+              data-testid="storage-location"
+              hoverTip="Copy"
+              clickTip="Copied"
+              variant="inline-compact"
+            >
               {modelArtifact.items[0]?.uri}
             </ClipboardCopy>
           </DashboardDescriptionListGroup>
           <DashboardDescriptionListGroup
             title="Source model format"
-            isEmpty={modelArtifact.size === 0}
+            isEmpty={modelArtifact.size === 0 || !modelArtifact.items[0].modelFormatName}
             contentWhenEmpty="No source model format"
           >
             {modelArtifact.items[0]?.modelFormatName}
diff --git a/frontend/src/pages/modelRegistry/screens/ModelVersionDetails/ModelVersionSelector.tsx b/frontend/src/pages/modelRegistry/screens/ModelVersionDetails/ModelVersionSelector.tsx
index 0f0db24a3b..cf00d689ea 100644
--- a/frontend/src/pages/modelRegistry/screens/ModelVersionDetails/ModelVersionSelector.tsx
+++ b/frontend/src/pages/modelRegistry/screens/ModelVersionDetails/ModelVersionSelector.tsx
@@ -65,6 +65,7 @@ const ModelVersionSelector: React.FC<ModelVersionSelectorProps> = ({
         <MenuSearch>
           <MenuSearchInput>
             <SearchInput
+              data-testid="search-input"
               value={input}
               aria-label="Filter menu items"
               onChange={(_event, value) => setInput(value)}
@@ -76,7 +77,7 @@ const ModelVersionSelector: React.FC<ModelVersionSelectorProps> = ({
             </HelperTextItem>
           </HelperText>
         </MenuSearch>
-        <MenuList>{menuListItems}</MenuList>
+        <MenuList data-testid="model-version-selector-list">{menuListItems}</MenuList>
       </MenuContent>
     </Menu>
   );
diff --git a/frontend/src/pages/modelRegistry/screens/GlobalModelVersionsTabs.tsx b/frontend/src/pages/modelRegistry/screens/ModelVersions/GlobalModelVersionsTabs.tsx
similarity index 90%
rename from frontend/src/pages/modelRegistry/screens/GlobalModelVersionsTabs.tsx
rename to frontend/src/pages/modelRegistry/screens/ModelVersions/GlobalModelVersionsTabs.tsx
index f731211341..6cc6c24b27 100644
--- a/frontend/src/pages/modelRegistry/screens/GlobalModelVersionsTabs.tsx
+++ b/frontend/src/pages/modelRegistry/screens/ModelVersions/GlobalModelVersionsTabs.tsx
@@ -3,12 +3,12 @@ import { useNavigate } from 'react-router-dom';
 import { PageSection, Tab, Tabs, TabTitleText } from '@patternfly/react-core';
 import '~/pages/pipelines/global/runs/GlobalPipelineRunsTabs.scss';
 import { ModelVersion, RegisteredModel } from '~/concepts/modelRegistry/types';
-import { ModelVersionsTabs, ModelVersionsTabTitle } from './const';
 import ModelVersionListView from './ModelVersionListView';
 import ModelDetailsView from './ModelDetailsView';
+import { ModelVersionsTab, ModelVersionsTabTitle } from './const';
 
 type GlobalModelVersionsTabProps = {
-  tab: ModelVersionsTabs;
+  tab: ModelVersionsTab;
   registeredModel: RegisteredModel;
   modelVersions: ModelVersion[];
 };
@@ -28,7 +28,7 @@ const GlobalModelVersionsTabs: React.FC<GlobalModelVersionsTabProps> = ({
       onSelect={(_event, eventKey) => navigate(`../${eventKey}`, { relative: 'path' })}
     >
       <Tab
-        eventKey={ModelVersionsTabs.VERSIONS}
+        eventKey={ModelVersionsTab.VERSIONS}
         title={<TabTitleText>{ModelVersionsTabTitle.VERSIONS}</TabTitleText>}
         aria-label="Model versions tab"
         data-testid="model-versions-tab"
@@ -38,7 +38,7 @@ const GlobalModelVersionsTabs: React.FC<GlobalModelVersionsTabProps> = ({
         </PageSection>
       </Tab>
       <Tab
-        eventKey={ModelVersionsTabs.DETAILS}
+        eventKey={ModelVersionsTab.DETAILS}
         title={<TabTitleText>{ModelVersionsTabTitle.DETAILS}</TabTitleText>}
         aria-label="Model Details tab"
         data-testid="model-details-tab"
diff --git a/frontend/src/pages/modelRegistry/screens/ModelDetailsView.tsx b/frontend/src/pages/modelRegistry/screens/ModelVersions/ModelDetailsView.tsx
similarity index 93%
rename from frontend/src/pages/modelRegistry/screens/ModelDetailsView.tsx
rename to frontend/src/pages/modelRegistry/screens/ModelVersions/ModelDetailsView.tsx
index 26de94f4b6..3f7600c69d 100644
--- a/frontend/src/pages/modelRegistry/screens/ModelDetailsView.tsx
+++ b/frontend/src/pages/modelRegistry/screens/ModelVersions/ModelDetailsView.tsx
@@ -5,9 +5,9 @@ import { RegisteredModel } from '~/concepts/modelRegistry/types';
 import DashboardDescriptionListGroup from '~/components/DashboardDescriptionListGroup';
 import EditableTextDescriptionListGroup from '~/components/EditableTextDescriptionListGroup';
 import EditableLabelsDescriptionListGroup from '~/components/EditableLabelsDescriptionListGroup';
-import RegisteredModelOwner from './RegisteredModelOwner';
-import ModelTimestamp from './ModelTimestamp';
-import { getLabels } from './utils';
+import RegisteredModelOwner from '~/pages/modelRegistry/screens/RegisteredModels/RegisteredModelOwner';
+import ModelTimestamp from '~/pages/modelRegistry/screens/components/ModelTimestamp';
+import { getLabels } from '~/pages/modelRegistry/screens/utils';
 
 type ModelDetailsViewProps = {
   registeredModel: RegisteredModel;
diff --git a/frontend/src/pages/modelRegistry/screens/ModelVersionListView.tsx b/frontend/src/pages/modelRegistry/screens/ModelVersions/ModelVersionListView.tsx
similarity index 92%
rename from frontend/src/pages/modelRegistry/screens/ModelVersionListView.tsx
rename to frontend/src/pages/modelRegistry/screens/ModelVersions/ModelVersionListView.tsx
index 67dfd68105..36abd14cf4 100644
--- a/frontend/src/pages/modelRegistry/screens/ModelVersionListView.tsx
+++ b/frontend/src/pages/modelRegistry/screens/ModelVersions/ModelVersionListView.tsx
@@ -17,9 +17,9 @@ import { EllipsisVIcon, FilterIcon } from '@patternfly/react-icons';
 import { SearchType } from '~/concepts/dashboard/DashboardSearchField';
 import { ModelVersion } from '~/concepts/modelRegistry/types';
 import SimpleDropdownSelect from '~/components/SimpleDropdownSelect';
+import EmptyModelRegistryState from '~/pages/modelRegistry/screens/EmptyModelRegistryState';
+import { filterModelVersions } from '~/pages/modelRegistry/screens/utils';
 import ModelVersionsTable from './ModelVersionsTable';
-import EmptyModelRegistryState from './EmptyModelRegistryState';
-import { filteredmodelVersions } from './utils';
 
 type ModelVersionListViewProps = {
   modelVersions: ModelVersion[];
@@ -27,7 +27,7 @@ type ModelVersionListViewProps = {
 };
 
 const ModelVersionListView: React.FC<ModelVersionListViewProps> = ({
-  modelVersions: unfilteredmodelVersions,
+  modelVersions: unfilteredModelVersions,
   registeredModelName: rmName,
 }) => {
   const [searchType, setSearchType] = React.useState<SearchType>(SearchType.KEYWORD);
@@ -38,9 +38,9 @@ const ModelVersionListView: React.FC<ModelVersionListViewProps> = ({
   const [isArchivedModelVersionKebabOpen, setIsArchivedModelVersionKebabOpen] =
     React.useState(false);
 
-  const filteredModelVersions = filteredmodelVersions(unfilteredmodelVersions, search, searchType);
+  const filteredModelVersions = filterModelVersions(unfilteredModelVersions, search, searchType);
 
-  if (unfilteredmodelVersions.length === 0) {
+  if (unfilteredModelVersions.length === 0) {
     return (
       <EmptyModelRegistryState
         title="No versions"
diff --git a/frontend/src/pages/modelRegistry/screens/ModelVersions.tsx b/frontend/src/pages/modelRegistry/screens/ModelVersions/ModelVersions.tsx
similarity index 96%
rename from frontend/src/pages/modelRegistry/screens/ModelVersions.tsx
rename to frontend/src/pages/modelRegistry/screens/ModelVersions/ModelVersions.tsx
index a2b1b5f9df..6ccc88ef61 100644
--- a/frontend/src/pages/modelRegistry/screens/ModelVersions.tsx
+++ b/frontend/src/pages/modelRegistry/screens/ModelVersions/ModelVersions.tsx
@@ -7,11 +7,11 @@ import useModelVersionsByRegisteredModel from '~/concepts/modelRegistry/apiHooks
 import useRegisteredModelById from '~/concepts/modelRegistry/apiHooks/useRegisteredModelById';
 import { ModelRegistrySelectorContext } from '~/concepts/modelRegistry/context/ModelRegistrySelectorContext';
 import GlobalModelVersionsTabs from './GlobalModelVersionsTabs';
-import { ModelVersionsTabs } from './const';
 import ModelVersionsHeaderActions from './ModelVersionsHeaderActions';
+import { ModelVersionsTab } from './const';
 
 type ModelVersionsProps = {
-  tab: ModelVersionsTabs;
+  tab: ModelVersionsTab;
 } & Omit<
   React.ComponentProps<typeof ApplicationsPage>,
   'breadcrumb' | 'title' | 'description' | 'loadError' | 'loaded' | 'provideChildrenPadding'
diff --git a/frontend/src/pages/modelRegistry/screens/ModelVersionsHeaderActions.tsx b/frontend/src/pages/modelRegistry/screens/ModelVersions/ModelVersionsHeaderActions.tsx
similarity index 100%
rename from frontend/src/pages/modelRegistry/screens/ModelVersionsHeaderActions.tsx
rename to frontend/src/pages/modelRegistry/screens/ModelVersions/ModelVersionsHeaderActions.tsx
diff --git a/frontend/src/pages/modelRegistry/screens/ModelVersionsTable.tsx b/frontend/src/pages/modelRegistry/screens/ModelVersions/ModelVersionsTable.tsx
similarity index 100%
rename from frontend/src/pages/modelRegistry/screens/ModelVersionsTable.tsx
rename to frontend/src/pages/modelRegistry/screens/ModelVersions/ModelVersionsTable.tsx
diff --git a/frontend/src/pages/modelRegistry/screens/ModelVersionsTableColumns.ts b/frontend/src/pages/modelRegistry/screens/ModelVersions/ModelVersionsTableColumns.ts
similarity index 100%
rename from frontend/src/pages/modelRegistry/screens/ModelVersionsTableColumns.ts
rename to frontend/src/pages/modelRegistry/screens/ModelVersions/ModelVersionsTableColumns.ts
diff --git a/frontend/src/pages/modelRegistry/screens/ModelVersionsTableRow.tsx b/frontend/src/pages/modelRegistry/screens/ModelVersions/ModelVersionsTableRow.tsx
similarity index 89%
rename from frontend/src/pages/modelRegistry/screens/ModelVersionsTableRow.tsx
rename to frontend/src/pages/modelRegistry/screens/ModelVersions/ModelVersionsTableRow.tsx
index 8a35711176..83c72ca4c2 100644
--- a/frontend/src/pages/modelRegistry/screens/ModelVersionsTableRow.tsx
+++ b/frontend/src/pages/modelRegistry/screens/ModelVersions/ModelVersionsTableRow.tsx
@@ -4,9 +4,9 @@ import { Text, TextVariants, Truncate, FlexItem } from '@patternfly/react-core';
 import { Link } from 'react-router-dom';
 import { ModelVersion } from '~/concepts/modelRegistry/types';
 import { ModelRegistrySelectorContext } from '~/concepts/modelRegistry/context/ModelRegistrySelectorContext';
-import ModelLabels from './ModelLabels';
-import ModelTimestamp from './ModelTimestamp';
-import { modelVersionUrl } from './routeUtils';
+import ModelLabels from '~/pages/modelRegistry/screens/components/ModelLabels';
+import ModelTimestamp from '~/pages/modelRegistry/screens/components/ModelTimestamp';
+import { modelVersionUrl } from '~/pages/modelRegistry/screens/routeUtils';
 
 type ModelVersionsTableRowProps = {
   modelVersion: ModelVersion;
diff --git a/frontend/src/pages/modelRegistry/screens/const.ts b/frontend/src/pages/modelRegistry/screens/ModelVersions/const.ts
similarity index 81%
rename from frontend/src/pages/modelRegistry/screens/const.ts
rename to frontend/src/pages/modelRegistry/screens/ModelVersions/const.ts
index f817b7d4e3..42133ed9e8 100644
--- a/frontend/src/pages/modelRegistry/screens/const.ts
+++ b/frontend/src/pages/modelRegistry/screens/ModelVersions/const.ts
@@ -1,4 +1,4 @@
-export enum ModelVersionsTabs {
+export enum ModelVersionsTab {
   VERSIONS = 'versions',
   DETAILS = 'details',
 }
diff --git a/frontend/src/pages/modelRegistry/screens/RegisteredModelListView.tsx b/frontend/src/pages/modelRegistry/screens/RegisteredModels/RegisteredModelListView.tsx
similarity index 100%
rename from frontend/src/pages/modelRegistry/screens/RegisteredModelListView.tsx
rename to frontend/src/pages/modelRegistry/screens/RegisteredModels/RegisteredModelListView.tsx
diff --git a/frontend/src/pages/modelRegistry/screens/RegisteredModelOwner.tsx b/frontend/src/pages/modelRegistry/screens/RegisteredModels/RegisteredModelOwner.tsx
similarity index 100%
rename from frontend/src/pages/modelRegistry/screens/RegisteredModelOwner.tsx
rename to frontend/src/pages/modelRegistry/screens/RegisteredModels/RegisteredModelOwner.tsx
diff --git a/frontend/src/pages/modelRegistry/screens/RegisteredModelTable.tsx b/frontend/src/pages/modelRegistry/screens/RegisteredModels/RegisteredModelTable.tsx
similarity index 100%
rename from frontend/src/pages/modelRegistry/screens/RegisteredModelTable.tsx
rename to frontend/src/pages/modelRegistry/screens/RegisteredModels/RegisteredModelTable.tsx
diff --git a/frontend/src/pages/modelRegistry/screens/RegisteredModelTableRow.tsx b/frontend/src/pages/modelRegistry/screens/RegisteredModels/RegisteredModelTableRow.tsx
similarity index 86%
rename from frontend/src/pages/modelRegistry/screens/RegisteredModelTableRow.tsx
rename to frontend/src/pages/modelRegistry/screens/RegisteredModels/RegisteredModelTableRow.tsx
index 179d53e81d..8a4617f5ae 100644
--- a/frontend/src/pages/modelRegistry/screens/RegisteredModelTableRow.tsx
+++ b/frontend/src/pages/modelRegistry/screens/RegisteredModels/RegisteredModelTableRow.tsx
@@ -4,11 +4,11 @@ import { ActionsColumn, Td, Tr } from '@patternfly/react-table';
 import { FlexItem, Text, TextVariants, Truncate } from '@patternfly/react-core';
 import { RegisteredModel } from '~/concepts/modelRegistry/types';
 import { ModelRegistrySelectorContext } from '~/concepts/modelRegistry/context/ModelRegistrySelectorContext';
+import ModelTimestamp from '~/pages/modelRegistry/screens/components/ModelTimestamp';
+import { registeredModelUrl } from '~/pages/modelRegistry/screens/routeUtils';
+import ModelLabels from '~/pages/modelRegistry/screens/components/ModelLabels';
+import { ModelVersionsTab } from '~/pages/modelRegistry/screens/ModelVersions/const';
 import RegisteredModelOwner from './RegisteredModelOwner';
-import ModelLabels from './ModelLabels';
-import ModelTimestamp from './ModelTimestamp';
-import { ModelVersionsTabs } from './const';
-import { registeredModelUrl } from './routeUtils';
 
 type RegisteredModelTableRowProps = {
   registeredModel: RegisteredModel;
@@ -51,7 +51,7 @@ const RegisteredModelTableRow: React.FC<RegisteredModelTableRowProps> = ({
           items={[
             {
               title: 'View details',
-              onClick: () => navigate(`${rmUrl}/${ModelVersionsTabs.DETAILS}`),
+              onClick: () => navigate(`${rmUrl}/${ModelVersionsTab.DETAILS}`),
             },
             {
               title: 'Archive model',
diff --git a/frontend/src/pages/modelRegistry/screens/RegisteredModelsTableColumns.ts b/frontend/src/pages/modelRegistry/screens/RegisteredModels/RegisteredModelsTableColumns.ts
similarity index 100%
rename from frontend/src/pages/modelRegistry/screens/RegisteredModelsTableColumns.ts
rename to frontend/src/pages/modelRegistry/screens/RegisteredModels/RegisteredModelsTableColumns.ts
diff --git a/frontend/src/pages/modelRegistry/screens/RegisteredModelsTableToolbar.tsx b/frontend/src/pages/modelRegistry/screens/RegisteredModels/RegisteredModelsTableToolbar.tsx
similarity index 100%
rename from frontend/src/pages/modelRegistry/screens/RegisteredModelsTableToolbar.tsx
rename to frontend/src/pages/modelRegistry/screens/RegisteredModels/RegisteredModelsTableToolbar.tsx
diff --git a/frontend/src/pages/modelRegistry/screens/ModelLabels.tsx b/frontend/src/pages/modelRegistry/screens/components/ModelLabels.tsx
similarity index 98%
rename from frontend/src/pages/modelRegistry/screens/ModelLabels.tsx
rename to frontend/src/pages/modelRegistry/screens/components/ModelLabels.tsx
index d0531526b4..37e84e51de 100644
--- a/frontend/src/pages/modelRegistry/screens/ModelLabels.tsx
+++ b/frontend/src/pages/modelRegistry/screens/components/ModelLabels.tsx
@@ -11,7 +11,7 @@ import {
 import React from 'react';
 import { ModelVersion, RegisteredModel } from '~/concepts/modelRegistry/types';
 import useDebounceCallback from '~/utilities/useDebounceCallback';
-import { getLabels } from './utils';
+import { getLabels } from '~/pages/modelRegistry/screens/utils';
 
 // Threshold count to decide whether to choose modal or popover
 const MODAL_THRESHOLD = 4;
diff --git a/frontend/src/pages/modelRegistry/screens/ModelTimestamp.tsx b/frontend/src/pages/modelRegistry/screens/components/ModelTimestamp.tsx
similarity index 100%
rename from frontend/src/pages/modelRegistry/screens/ModelTimestamp.tsx
rename to frontend/src/pages/modelRegistry/screens/components/ModelTimestamp.tsx
diff --git a/frontend/src/pages/modelRegistry/screens/utils.ts b/frontend/src/pages/modelRegistry/screens/utils.ts
index 5e9dd9f93f..ac0350fe98 100644
--- a/frontend/src/pages/modelRegistry/screens/utils.ts
+++ b/frontend/src/pages/modelRegistry/screens/utils.ts
@@ -7,12 +7,12 @@ export const getLabels = <T extends ModelRegistryBase['customProperties']>(
 ): string[] =>
   Object.keys(customProperties).filter((key) => customProperties[key].string_value === '');
 
-export const filteredmodelVersions = (
-  unfilteredmodelVersions: ModelVersion[],
+export const filterModelVersions = (
+  unfilteredModelVersions: ModelVersion[],
   search: string,
   searchType: SearchType,
 ): ModelVersion[] =>
-  unfilteredmodelVersions.filter((mv: ModelVersion) => {
+  unfilteredModelVersions.filter((mv: ModelVersion) => {
     if (!search) {
       return true;
     }